From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9150E22A4F0; Tue, 24 Jun 2025 17:02:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750784552; cv=none; b=rNtme9TsfAf+sLJ814BggbjrhKKVXs07aA614yx4Dko61NmANMMxaX7oAW5TEnYQHL4XT4bl7tx6mUolDU6nlaS4jaZ4FBQEChpu5IaghX1NFRF+1tYE6kyqxhyBcWwytu/f54vgZU3Bp724ByCQDVOpbj2yPJiaXyJ+7O/Ve/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750784552; c=relaxed/simple; bh=d4OBpBu6hw1KDprnFdRVmV5CvEfQ//NZYDFWukP17pk=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=DZ4PzpoAMTEMZ1aNAQHR8uIWxeoB0JFlF+DBd20vPcfa10HGRKiprbAKLjyg0hdfZB1Gt8Axd68YiZwAn+dZ4l0QqJ8th+K6eaFagZEAyZSbTX3OXojjugvYdwZYbFblmm9LIVb1huXhdip5jnBtm4bfGwCAAFzASyjCRVDGizM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oTtc8QNV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oTtc8QNV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BABFC4CEE3; Tue, 24 Jun 2025 17:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750784551; bh=d4OBpBu6hw1KDprnFdRVmV5CvEfQ//NZYDFWukP17pk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oTtc8QNV8oFEiQElaJ2CWLUj9R+gB1KyUp+AXB3Lm5QdzjPNSzVnVtPemnTy/UAaU Sr/0QN3tUcdBrwAC7mrO0gI2HUJaM2eGIer7PjH5NVzJDY8r/WbHHgi02r2zhQ36IM Tim15ufyv+fXalJlBgPhMGTpCLksT62dtT5VCBatN8Yaer0i+hkzh9OvNiWNn7Rwas 3bGJlA9ecNonS1A8Nl2eGIAOex0oDoAYiOsMYiwmqfwKFe2AHntbmFctpBpc6m0ACI gJf1pK+fhq0n+jaQUIhOl6LYW455kb6OQdhoNyrNEMNWZGTiupPkurh2VPbAqiWtlt P26Re1PWYMyaA== Received: from [193.57.185.11] (helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uU72S-009awv-KE; Tue, 24 Jun 2025 18:02:28 +0100 Date: Tue, 24 Jun 2025 18:02:27 +0100 Message-ID: <877c11f4yk.wl-maz@kernel.org> From: Marc Zyngier To: Catalin Marinas Cc: Yeoreum Yun , pcc@google.com, will@kernel.org, broonie@kernel.org, anshuman.khandual@arm.com, joey.gouly@arm.com, yury.khrustalev@arm.com, oliver.upton@linux.dev, frederic@kernel.org, akpm@linux-foundation.org, surenb@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v9 03/10] arm64/kvm: expose FEAT_MTE_TAGGED_FAR feature to guest In-Reply-To: References: <20250618084513.1761345-1-yeoreum.yun@arm.com> <20250618084513.1761345-4-yeoreum.yun@arm.com> <86ldppc86c.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 193.57.185.11 X-SA-Exim-Rcpt-To: catalin.marinas@arm.com, yeoreum.yun@arm.com, pcc@google.com, will@kernel.org, broonie@kernel.org, anshuman.khandual@arm.com, joey.gouly@arm.com, yury.khrustalev@arm.com, oliver.upton@linux.dev, frederic@kernel.org, akpm@linux-foundation.org, surenb@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 24 Jun 2025 17:33:52 +0100, Catalin Marinas wrote: > > Hi Marc, > > On Wed, Jun 18, 2025 at 05:43:07PM +0100, Marc Zyngier wrote: > > In general, please use a patch title format that matches the one used > > for the subsystem. For KVM, that'd be "KVM: arm64: Expose ..."/ > [...] > > > case SYS_ID_AA64PFR2_EL1: > > > - /* We only expose FPMR */ > > > - val &= ID_AA64PFR2_EL1_FPMR; > > > + mask = ID_AA64PFR2_EL1_FPMR; > > > + > > > + if (kvm_has_mte(vcpu->kvm)) > > > + mask |= ID_AA64PFR2_EL1_MTEFAR; > > > + > > > + val &= mask; > > > > I don't think there is a need for an extra variable, and you could > > follow the pattern established in this file by writing this as: > > > > val &= (ID_AA64PFR2_EL1_FPMR | > > (kvm_has_mte(vcpu->kvm) ? ID_AA64PFR2_EL1_MTEFAR : 0)); > > > > Not a big deal though. > > I can make the changes locally. Are you ok with the patch otherwise? Yup, that'd fine by me. With this fixed: Acked-by: Marc Zyngier M. -- Jazz isn't dead. It just smells funny.