From: "Eric W. Biederman" <ebiederm@xmission.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] userns: Add forward declaration of struct seq_file in user_namespace.h
Date: Sat, 31 May 2025 06:07:20 -0500 [thread overview]
Message-ID: <877c1xghsn.fsf@email.froward.int.ebiederm.org> (raw)
In-Reply-To: <aDqq4rg9rTKRur8Y@gondor.apana.org.au> (Herbert Xu's message of "Sat, 31 May 2025 15:08:18 +0800")
Herbert Xu <herbert@gondor.apana.org.au> writes:
> On Fri, May 30, 2025 at 08:27:14AM -0500, Eric W. Biederman wrote:
>>
>> That description seems to be lacking something. The code as has been
>> fine since 2014 and there is no conditional compilation involved.
>
> I'm happy to drop the fixes header. There is no need to backport
> this.
The fixes tag isn't wrong.
>> Did some other change cause a declaration of seq_file not to be present?
>> Did user_namespace.h get included somewhere new and that new location
>> doesn't wind up declaring seq_file?
>
> The seq_file forward declaration is currently being provided by
> linux/sched.h. I tried removing it and found this issue.
Thanks.
That is the interesting information that I would appreciate to see
in the change log.
If someone has to play code archaeologist and has to look at the
history, this is exactly the information that is needed to understand
why the change was made.
Eric
prev parent reply other threads:[~2025-05-31 11:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 8:35 Herbert Xu
2025-05-30 13:27 ` Eric W. Biederman
2025-05-31 7:08 ` Herbert Xu
2025-05-31 11:07 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c1xghsn.fsf@email.froward.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®