mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vaibhav Jain <vaibhav@linux.ibm.com>
To: Nicholas Piggin <npiggin@gmail.com>,
	Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Cc: "Gautham R . Shenoy" <ego@linux.vnet.ibm.com>,
	Michael Neuling <mikey@neuling.org>,
	Stewart Smith <stewart@linux.ibm.com>,
	Linux-MIPS <linux-mips@linux-mips.org>,
	linux-arch <linux-arch@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>, James Hogan <jhogan@kernel.org>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [Skiboot] [PATCH] opal/hmi: Wakeup the cpu before reading core_fir
Date: Thu, 23 Aug 2018 17:02:51 +0530	[thread overview]
Message-ID: <877ekhnwrg.fsf@vajain21.in.ibm.com> (raw)
In-Reply-To: <20180821133842.1b13e972@roar.ozlabs.ibm.com>

Thanks for reviewing this patch Nick

Nicholas Piggin <npiggin@gmail.com> writes:
>
> Would it be feasible to enumerate the ranges of scoms that require
> special wakeup and check for those in xscom_read/write, and warn if
> spwkup was not set?
>
I think that might be racy (Vaidy please correct if I am wrong) as a
core can change its state when we read its sleep state and when we do
the actual xscom to read the core_fir.

-- 
Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
Linux Technology Center, IBM India Pvt. Ltd.


  reply	other threads:[~2018-08-23 11:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-18 18:10 [PATCH v8 0/2] MIPS: Override barrier_before_unreachable() to fix microMIPS Paul Burton
2018-08-18 18:10 ` [PATCH v8 1/2] kbuild: Allow asm-specific compiler_types.h Paul Burton
2018-08-20  5:04   ` Masahiro Yamada
2018-08-20 18:34     ` Paul Burton
2018-08-20 22:36       ` [PATCH v9 0/2] MIPS: Override barrier_before_unreachable() to fix microMIPS Paul Burton
2018-08-20 22:36         ` [PATCH v9 1/2] kbuild: Allow arch-specific asm/compiler.h Paul Burton
2018-08-21  2:49           ` Masahiro Yamada
2018-08-21 17:00             ` Paul Burton
     [not found]           ` <20180820140605.11846-1-vaibhav@linux.ibm.com>
2018-08-21  3:38             ` [Skiboot] [PATCH] opal/hmi: Wakeup the cpu before reading core_fir Nicholas Piggin
2018-08-23 11:32               ` Vaibhav Jain [this message]
2018-08-20 22:36         ` [PATCH v9 2/2] MIPS: Workaround GCC __builtin_unreachable reordering bug Paul Burton
2018-08-18 18:10 ` [PATCH v8 " Paul Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ekhnwrg.fsf@vajain21.in.ibm.com \
    --to=vaibhav@linux.ibm.com \
    --cc=arnd@arndb.de \
    --cc=ego@linux.vnet.ibm.com \
    --cc=jhogan@kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=mikey@neuling.org \
    --cc=npiggin@gmail.com \
    --cc=ralf@linux-mips.org \
    --cc=stewart@linux.ibm.com \
    --cc=svaidy@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®