From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753276AbdKIVC1 (ORCPT ); Thu, 9 Nov 2017 16:02:27 -0500 Received: from ozlabs.org ([103.22.144.67]:49131 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbdKIVCZ (ORCPT ); Thu, 9 Nov 2017 16:02:25 -0500 From: Michael Ellerman To: Anju T Sudhakar Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, maddy@linux.vnet.ibm.com, anju@linux.vnet.ibm.com Subject: Re: [PATCH] powerpc/powernv: Fix IMC_MAX_PMU macro In-Reply-To: <1510229426-5547-1-git-send-email-anju@linux.vnet.ibm.com> References: <1510229426-5547-1-git-send-email-anju@linux.vnet.ibm.com> Date: Fri, 10 Nov 2017 08:02:23 +1100 Message-ID: <877euzp3mo.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Anju T Sudhakar writes: > IMC_MAX_PMU is used for static storage (per_nest_pmu_arr) which holds > nest pmu information. Current value for the macro is 32 based on > the initial number of nest pmu units supported by the nest microcode. > Currently 29 nest units are enabled based on the system configuration. > But going forward, microcode could support more nest units (max of 64 > nest units). Hence fix the value for the macro. There should be no reason to have a hard coded limit. We should just fix the code to dynamically size the array based on what's found in the device tree. cheers > Fixes:8f95faaac56c1 ('powerpc/powernv: Detect and create IMC device') > Signed-off-by: Anju T Sudhakar > --- > arch/powerpc/include/asm/imc-pmu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/include/asm/imc-pmu.h b/arch/powerpc/include/asm/imc-pmu.h > index 7f74c28..f9f0f2e 100644 > --- a/arch/powerpc/include/asm/imc-pmu.h > +++ b/arch/powerpc/include/asm/imc-pmu.h > @@ -23,7 +23,7 @@ > /* > * For static allocation of some of the structures. > */ > -#define IMC_MAX_PMUS 32 > +#define IMC_MAX_PMUS 64 > > /* > * Compatibility macros for IMC devices > -- > 2.7.4