From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751165AbdGaKhY (ORCPT ); Mon, 31 Jul 2017 06:37:24 -0400 Received: from ozlabs.org ([103.22.144.67]:46155 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750847AbdGaKhX (ORCPT ); Mon, 31 Jul 2017 06:37:23 -0400 From: Michael Ellerman To: Qiang Zhao , "oss\@buserror.net" Cc: "valentin.longchamp\@keymile.com" , "linuxppc-dev\@lists.ozlabs.org" , "linux-kernel\@vger.kernel.org" Subject: RE: [PATCH v2] qe: fix compile issue for arm64 In-Reply-To: References: <1500867555-36277-1-git-send-email-qiang.zhao@nxp.com> <87o9s5dr6n.fsf@concordia.ellerman.id.au> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Mon, 31 Jul 2017 20:37:21 +1000 Message-ID: <877eyo6gf2.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Qiang Zhao writes: > Fri 7/28/2017 2:14 PM, Michael Ellerman wrote: > >> -----Original Message----- >> From: Michael Ellerman [mailto:mpe@ellerman.id.au] >> Sent: Friday, July 28, 2017 2:14 PM >> To: Qiang Zhao ; oss@buserror.net >> Cc: valentin.longchamp@keymile.com; linuxppc-dev@lists.ozlabs.org; linux- >> kernel@vger.kernel.org; Qiang Zhao >> Subject: Re: [PATCH v2] qe: fix compile issue for arm64 >> >> Zhao Qiang writes: >> >> > Signed-off-by: Zhao Qiang >> > --- >> > Changes for v2: >> > - include all Errata QE_General4 in #ifdef >> > >> > drivers/soc/fsl/qe/qe.c | 2 ++ >> > 1 file changed, 2 insertions(+) >> >> AFAICS this driver can only be built on PPC, what am I missing? >> >> config QUICC_ENGINE >> bool "Freescale QUICC Engine (QE) Support" >> depends on FSL_SOC && PPC32 >> >> cheers > > I sent another patchset to support it on arm64. Where? I don't see it. Shouldn't this patch be part of that series? Otherwise when that series is merged the build will break on arm64. cheers