From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755444AbdERIrR (ORCPT ); Thu, 18 May 2017 04:47:17 -0400 Received: from ozlabs.org ([103.22.144.67]:43835 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755381AbdERIrO (ORCPT ); Thu, 18 May 2017 04:47:14 -0400 From: Michael Ellerman To: "Aneesh Kumar K.V" , akpm@linux-foundation.org, Anshuman Khandual Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v3 2/2] powerpc/mm/hugetlb: Add support for 1G huge pages In-Reply-To: <852b601c-a044-0445-e97d-d17d76ec1154@linux.vnet.ibm.com> References: <1494995292-4443-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1494995292-4443-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <87fug2loze.fsf@concordia.ellerman.id.au> <852b601c-a044-0445-e97d-d17d76ec1154@linux.vnet.ibm.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Thu, 18 May 2017 18:47:01 +1000 Message-ID: <877f1elfga.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Aneesh Kumar K.V" writes: > On Thursday 18 May 2017 10:51 AM, Michael Ellerman wrote: >> "Aneesh Kumar K.V" writes: >> >>> POWER9 supports hugepages of size 2M and 1G in radix MMU mode. This patch >>> enables the usage of 1G page size for hugetlbfs. This also update the helper >>> such we can do 1G page allocation at runtime. >>> >>> We still don't enable 1G page size on DD1 version. This is to avoid doing >>> workaround mentioned in commit: 6d3a0379ebdc8 (powerpc/mm: Add >>> radix__tlb_flush_pte_p9_dd1() >>> >>> Signed-off-by: Aneesh Kumar K.V >>> --- >>> arch/powerpc/include/asm/book3s/64/hugetlb.h | 10 ++++++++++ >>> arch/powerpc/mm/hugetlbpage.c | 7 +++++-- >>> arch/powerpc/platforms/Kconfig.cputype | 1 + >>> 3 files changed, 16 insertions(+), 2 deletions(-) >> >> I think this patch is OK, but it's very confusing because it doesn't >> mention that it's only talking about *generic* gigantic page support. > > What you mean by generic gigantic page ? what is supported here is the > gigantic page with size 1G alone ? What about 16G pages on pseries. And all the other gigantic page sizes that Book3E supports? cheers