From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752987AbdBNKqd (ORCPT ); Tue, 14 Feb 2017 05:46:33 -0500 Received: from ozlabs.org ([103.22.144.67]:58791 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbdBNKqb (ORCPT ); Tue, 14 Feb 2017 05:46:31 -0500 From: Michael Ellerman To: Ravi Bangoria , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: benh@kernel.crashing.org, paulus@samba.org, lsorense@csclub.uwaterloo.ca, oohall@gmail.com, naveen.n.rao@linux.vnet.ibm.com, ast@kernel.org, chris@distroguy.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, anton@samba.org, paul.gortmaker@windriver.com, bauerman@linux.vnet.ibm.com, viro@zeniv.linux.org.uk, christophe.leroy@c-s.fr, duwe@lst.de, oss@buserror.net, Ravi Bangoria Subject: Re: [PATCH v3 2/2] powerpc: emulate_step tests for load/store instructions In-Reply-To: <1487063803-10848-3-git-send-email-ravi.bangoria@linux.vnet.ibm.com> References: <1487063803-10848-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1487063803-10848-3-git-send-email-ravi.bangoria@linux.vnet.ibm.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 14 Feb 2017 21:46:25 +1100 Message-ID: <877f4tm4n2.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ravi Bangoria writes: > diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile > index 0e649d7..ddc879d 100644 > --- a/arch/powerpc/lib/Makefile > +++ b/arch/powerpc/lib/Makefile > @@ -33,3 +33,7 @@ obj-$(CONFIG_ALTIVEC) += xor_vmx.o > CFLAGS_xor_vmx.o += -maltivec $(call cc-option,-mabi=altivec) > > obj-$(CONFIG_PPC64) += $(obj64-y) > + > +ifeq ($(CONFIG_PPC64), y) > +obj-$(CONFIG_KPROBES_SANITY_TEST) += test_emulate_step.o > +endif FYI, the right way to do that is: obj64-$(CONFIG_KPROBES_SANITY_TEST) += test_emulate_step.o obj-$(CONFIG_PPC64) += $(obj64-y) And in this Makefile you don't need to add the second line because it's already there. cheers