From: Rodolfo Giometti <giometti@enneenne.com>
To: rajender.reddy@stesalit.in
Cc: afd@ti.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
security@kernel.org, linux-api@vger.kernel.org,
trivial@kernel.org
Subject: Re: Support for BQ28Z610 Battery Monitor IC
Date: Tue, 5 Sep 2017 09:03:26 +0200 [thread overview]
Message-ID: <877fa5e7-2f4b-08a0-6d31-b128d56d119a@enneenne.com> (raw)
In-Reply-To: <BA23DB07EF784484A47D0FA46BA628BA.MAI@stesalit-inc.com>
On 04/09/2017 15:53, rajender.reddy@stesalit.in wrote:
> Dear Rodolfo Giometti,
>
> As discussed please find attached patch.
> Please let me know if you need more details.
It looks OK to me... however:
- rewrite the patch's title as "power bq27xxx_battery: add support for BQ28Z610
battery monitor IC"
- align the "=" characters as follow:
+ [BQ28Z610] = {
+ [BQ27XXX_REG_CTRL] = 0x00,
+ [BQ27XXX_REG_TEMP] = 0x06,
+ [BQ27XXX_REG_INT_TEMP] = INVALID_REG_ADDR,
+ [BQ27XXX_REG_VOLT] = 0x08,
...
Then send the patch to the mail list or maintainers ad described into the
MAINTAINERS file and adding me in Cc.
Good job! :-)
Ciao,
Rodolfo
--
HCE Engineering e-mail: giometti@hce-engineering.it
GNU/Linux Solutions giometti@enneenne.com
Linux Device Driver giometti@linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
Cosino Project - the quick prototyping embedded system - www.cosino.it
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
parent reply other threads:[~2017-09-05 7:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <BA23DB07EF784484A47D0FA46BA628BA.MAI@stesalit-inc.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fa5e7-2f4b-08a0-6d31-b128d56d119a@enneenne.com \
--to=giometti@enneenne.com \
--cc=afd@ti.com \
--cc=akpm@linux-foundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rajender.reddy@stesalit.in \
--cc=security@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®