From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755548AbcHBBOv (ORCPT ); Mon, 1 Aug 2016 21:14:51 -0400 Received: from relmlor3.renesas.com ([210.160.252.173]:42320 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751654AbcHBBOa (ORCPT ); Mon, 1 Aug 2016 21:14:30 -0400 X-IronPort-AV: E=Sophos;i="5.22,559,1449500400"; d="scan'";a="216444571" Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Message-ID: <877fc0hte3.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Kevin Hilman CC: Liam Girdwood , Mark Brown , , Sekhar Nori , Jaroslav Kysela , Takashi Iwai , open list Subject: Re: [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue In-Reply-To: <20160801233610.10479-1-khilman@baylibre.com> References: <20160801233610.10479-1-khilman@baylibre.com> User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Date: Tue, 2 Aug 2016 01:13:40 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: TY1PR01CA0095.jpnprd01.prod.outlook.com (10.167.154.13) To KL1PR0601MB1447.apcprd06.prod.outlook.com (10.169.69.25) X-MS-Office365-Filtering-Correlation-Id: 3677457b-89df-404b-ba92-08d3ba723dea X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1447;2:N7MoProaWQyExidLjmF0cR69A0/iAuU3athVnOFlqGZXEwHzhnnQUz0Ng86Ic/jrudIkZpLAxpMOqYrqmELKhDqLS26OmDvPno+sARl8m4M28GTjJBlSASQ7w0gpZlRzq8jPMpaZf1hqrUH4CQ+h/cg4lVH6zW0+KS32Sqhq8h1JUTuXABeVmi97XKI7E7Z2;3:WGxjG/89/rD+6+DH/eeOMarYK4siBO4ye9lyTtdwQsWEX/KnS3+QkRQbL1SDl6Ej0cPN3SH8IvwJfkmJdIoq1sFFYoGz1ULvEDs1FMkL2iQ1gNP1rBqjPQxUwXGqXIwi X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:KL1PR0601MB1447; X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1447;25:sE6vVPk45zGQBzy7bcHpkeZ4VzjePrLv/1yzIrNPAo+x288ElupEinvlmm9gnUE1T5as8lj9h0zrLqHwf4aEfUVJzPBQTDMkilOfmP5hw/Gb1b11ASw/RVYWG+MJQTe1XXzENa2J+sJUNf4Y2nXwKMjYXJYYSIDqCVqygbIYw/cs+2Fz/1f2J7Sv0pElFtHYLos1IbRBSOgExP7gHZ/tYUvBQ7oxArx01pps8j0VN2Unsr8S61qHiDskE145BVOHq/n2tUqqkFxw19RvwVz4HlTrdwhd1sj+JsjRU4AYBEzLDKX7COqB606If5/OeP0fkl8hU1SEMp3XptQ53W0mZl0/ocxGmAy6sw/YQiAwtyxl1RGFJTVnKpM83fFgsImSkknyOyQJBE3JwTcq/ZPr8xRl4fuvVpMs2eNr7obnmg2L+xYcZ0pxdsOaepVFK8X/sRqvIkIXRl5rMX6okvmkjDmwyOtvdCL/tdFj100n63zl864m/sRc1BuN1LjYyeuQef4osE0ZfGCNF9cK4DOsbP53/HeNg9dSFi8UgkDZ5chafrAQ1i+y53FyTi2yN35YSEUoawTWGiMOCqlD7cg0cCQEyM4j5a/Ab74gCEXd+GUmM8RAAAOtXUQRq03b+j1uqQnad+yYa9m8oBaY84IvV3yUibiNx0d8mA79+tnsv7LGAJuhzx0j1mXsB9tX34i0BCNk4n42jPnnlLrih9orBw==;31:5+Cyzri8qmePKWSK/evFRgnI/77HDiJonXJZD4hVRaATBLg7TDbvqMux10K8g2ehfeDHyRp3HalfcN4j+K4gJ2/UWp6ZCFBSat9tLkO6ltzxU1plEAFIH2vj/sfF3A8k2PtmaPuZRc2ujq5aEoEVO4fguAzN6As2PK7AHRwllFp+MVyCQg/bVr2KxaPg818b09RR44QlqQEbaqblTTjZJZQjaIkJvukfXbKBwn10n6U= X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1447;20:aOen0DTdIxZb9/T709czoo1RPIu7RUwAndJ/+h0/6WPdseSli3yyyrsEmk71KqXCBWSBf0s1A29Mf2CDpwGbpMVEynhQU5VVnKKQMFndy/1NiPIznUt+5bF9c5yxuwK0KH8bqnodNAli7VMVvkXn72D157OfGpeFQJjoNMkC1IbocauX3GWlJ4enmJ4YnJhNf6Q/a9cG1IhrQxFrUhGGbtYJG5Y53jUT1AKXVKjFizbIzrXrucG0Us6kVvVKFnvmJo7+TD/O3jWDLxjvs4cJ/gf4ed5qfdA6O68aMJ9f3Kf5qrLlk96KFhZPGr7V2Qus/upIPnvTJaU/+/byxFZeFRIAhTe+3Qb+X63JaaLp6Im7shbYPManTTcgPRvI5+T1RtnlYu3HgRRmb+z8bXcSiEs6bs/6Sc3wF3gLGSryj4nNeDhMRuLuPjVe1g26V2c7NY/3AzArAhBMDNpgwpuslRtdRf75UpYIj2KeUJE7vvpdfum6+/u2pCnCV7Jyc/fw;4:crPYDKPuzTaqC1XiOznWWQSZRKP0dhnmjthBCKLLIUUJXUb/PLKBorhwjk0w2zl0C4QMr0xk9UkOUW4KTsCjF6bPXFnI/zIaUt43SdewV0ELvbjNrOQE1S08rBhjrd4XDcADL+coOIxXWbeTSYyRNng/4LRmzJkhvl0D4oyICUjxveKe71fbXM5WbSoKr/rZIEdQnKSX5LsM3aHys87ldtkniV0pbe4T/kZ43w4AnAb+fiUojv4/UMUQzqm7qmMHxGwtvpkitl9FTKVwjHVbuV4AjJblbm/BaQUCw9UnOo6VhBnS3nO1WXHcSRVkAEoiJCCJg7KM4rfJXb6D/fYwL9nqZ7d1O0tLAlJ9epg9gIJBK1rDq60kM5wpZnSwjT8oKSztnobGtSi64Z7YQm1BLYF8DyusZ/UH19d6pRHnOS6zzT38o7wq+/tOjHoZ0CrD X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(31051911155226); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:KL1PR0601MB1447;BCL:0;PCL:0;RULEID:;SRVR:KL1PR0601MB1447; X-Forefront-PRVS: 0022134A87 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(199003)(189002)(586003)(69596002)(77096005)(19580405001)(19580395003)(36756003)(46406003)(105586002)(86362001)(53416004)(2950100001)(83506001)(33646002)(42186005)(106356001)(50986999)(101416001)(81156014)(76176999)(54356999)(97736004)(110136002)(3846002)(6116002)(23726003)(189998001)(4326007)(2906002)(50466002)(47776003)(4001350100001)(92566002)(7736002)(305945005)(68736007)(8676002)(345774005)(66066001)(81166006)(7846002)(16060500001);DIR:OUT;SFP:1102;SCL:1;SRVR:KL1PR0601MB1447;H:morimoto-PC.renesas.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;KL1PR0601MB1447;23:AE4GdtnjmT9fxYWw2TUIf2hlNbG4o8/rQPiuLSD?= =?us-ascii?Q?oUeTakf9IPP1IjHWIPqDYRecE/eL/V49QUMvlncwnCmAsN/nLWbnpNiQ+kxF?= =?us-ascii?Q?Ibm2wQg6UIP+pKWHGDhZ/3P8AXeopmYEQ8mMygO7TAA6w+P+S07ZeoMcyNI6?= =?us-ascii?Q?ZwEL0zFEEn00noUJoFkXF302lScFE32G7tP1ENuIpAUim9RxvvPj5K33tyxd?= =?us-ascii?Q?v9CxxEcGAYv4cYqIpDL4ime8Ma/7aZZiWpUg+L8obGkFYzEdoU8HxFpbz5vo?= =?us-ascii?Q?f8uN3iF107sN8+YgvgMhdAwQAKIjhMN4IsC3hjpoF5ab6HxvK8GAj0bktwq9?= =?us-ascii?Q?2w+vNH/pHrlBL8FWRhNaqLdepXJnjTyrOxDwWQ2zE+AOHsHCI8UwaY2Qmfcb?= =?us-ascii?Q?5uEwk4lz4zqNCNJq3EQC3yhjMPGLPSFWgrMd27siVBl74RaIVw3gYk8ZuurX?= =?us-ascii?Q?du5ZjYgin/9ra4twQdCK6WBbE4084tjoVTVt8cltS16Hn73/+ciPcZVJLb2h?= =?us-ascii?Q?3mx1UArjgYkyyCtKmZKWHWEmtshKQ7/GHr3rBT3yDRpfAjLO5kPWPLrzhCFB?= =?us-ascii?Q?8QjXE8/urgwwc/TTcTawefMUdc+oy04tmr1fPLDobUoJEvh+ZtTBzlY9ivz5?= =?us-ascii?Q?fUnO+xltUzICm/oeO2lh0sG/jGRgSgJeLYbSid3cKFCLO3MBL0IC7Em8Fcux?= =?us-ascii?Q?xONN6wR+lep97I+F50FAMznX9JMlbt4rPHBOVKtT9EyH+ns0RzPeMy0fxpV0?= =?us-ascii?Q?cL2FijyYG5NqPZ9ajSecc0hPh4WyvIc451nG6pCqLZRb4KRXAcT/IQjWAWVJ?= =?us-ascii?Q?4B8keSr85mUhhxr4ZNSGo5XOckagG1DccgLX0yD36E00dvhco2MEBq3nz/Tg?= =?us-ascii?Q?4cfldHdsF9aakqVWRePHrcp7/N8VXBcMP/4WcrDYoYFFmrTwZcMXwXeaFz+k?= =?us-ascii?Q?PLWqwlOonQB3JkIE3bmy7C6A7QBR6vwbOSRvNXXxvbiMZfL1iOsPl5dC7Wvk?= =?us-ascii?Q?WifeM4JnaWVyN8imtAcYg268wtz7LTsMvRf7RfFlHr9rLijfRa2W7dIP7VSV?= =?us-ascii?Q?TtafF8cGK89/jLu9pf5W9KYHya+jg4LDxcPdvil1jVvpviu3RQdV4mG4Qr8l?= =?us-ascii?Q?T54UYdFNs8GXPYWTG43H66atHg/CF0mnRW8jDfTB8skrmCgmXEUd7lg=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1447;6:c2F9wPl0P2geHD+WhpHVoH+WPuPSkA9mLRHwTQ3m6WIAVj1dj2pnoC4GObUHdjgEq46DoyNQwB0Yb0Kxx11G6pIxPCsMmx9w3mdZZBG/f4w//ylTRBxGDPY/Rqqpl3hDYijqRriA8kWVCaHViRsD5qu1IORH/GvQpbwvUtG4tBefiINc+UWN2AhtdN9xFxTZlaxXwKY9GMbFPihLpXkg47cDsE3ZP1V30AePmHXrZNQRrmz+TwYW5Apo38hueUw8qrjL0Zx6OyQ556Y9lY8eFd9YNGF0ydUovU7MSjZbyD2YYt/hYPbaQJoRV8FgaXzLMp7IeO8BGmvx/CleYDUW7Q==;5:sWvw0XTytdqkPHD8VWSCCVa2XEw/37BeOhldwpEEs2nH7ZeFDmai5Vd4dhLBWfHLizSoiKfgAJgYZIajlNE2eImOCndJRBq3JYNuRtXyIeMs1chwWy/qCpSlmcNpF8sDGz4AfujGRCtrgJKiTStDUA==;24:FXkj7TTMbBUJj+mutIhRW1VAZ2qVLSShYH8GB3FEWYR4shfGRlhJ/W5HCSO2ce+1TkUvhoBwZgW0kCGcC7T72bX7tGUG2kWYBrMqF854FdQ=;7:pMYTzl5bOZl/u53KnH4d48gDAV7FkMl3Gxtbz8UHfkiElPrZQk7BONR7Y5Jwff7KH9bOS1eHQQGATfQv3h+CB4HR881h0+AWhVYAOcYklC2rLoyoNmkathzqi3R3a90SKmwCUHgT5SANAN+tEmwkS6m8nSeRxkHy2mf6n1kKs97RYAbrvXzFbUykYSPo6moQI2WAnGN6PfnIVbBxemjJ2MbLctE+Zm+4oAO1OLavH5cGTGUf6hAV34XRYZgsabD4 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1447;20:OAK2cwL13s75JJckI/6BY0h7vY8Dd1yu4UDJaj1r9NUWIUFB1SvyXgZDnBK8WoaNZUmKq74BDiQNmrnCTrCS0i+wZ1wVWXVa9bRR7u6ie7dlrIEXQGZGQ/qV0gs16e9wQ6wWn38Q2KCvXvA035RlLRqtQkIsTUbYG4jjcwkm3SQ= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2016 01:13:40.8305 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB1447 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kevin Thank you for your patch > An ASoC driver using simple-card, when built as a module gets the > following error at module load time: > > [ 23.571873] simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0) > [ 23.712726] simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0) > > fix this by including simple-card-utils.o symbols in the module build > its symols are resolved correctly. > > Tested on Davinci DA850-EVM using snd_soc_edma, snc_soc_davinci_mcasp, > with all of ASoC built as modules. > > Cc: Sekhar Nori > Signed-off-by: Kevin Hilman > --- Hmm... strange... simple-card-utils will be used not only simple-card in the future, thus it should be build separately. And, snd_soc_of_parse_daifmt() and snd_soc_of_parse_card_name() are already exported on soc-core.c ? I tried it as module, but no error for me ... CHK kernel/config_data.h LD sound/soc/generic/built-in.o CC [M] sound/soc/generic/simple-card-utils.o CC [M] sound/soc/generic/simple-card.o LD [M] sound/soc/generic/snd-soc-simple-card.o LD sound/soc/built-in.o LD sound/built-in.o ... MODPOST 7 modules Kernel: arch/arm/boot/Image is ready Kernel: arch/arm/boot/Image is ready CC sound/soc/generic/simple-card-utils.mod.o CC sound/soc/generic/snd-soc-simple-card.mod.o GZIP arch/arm/boot/compressed/piggy_data LD [M] sound/soc/generic/simple-card-utils.ko LD [M] sound/soc/generic/snd-soc-simple-card.ko AS arch/arm/boot/compressed/piggy.o LD arch/arm/boot/compressed/vmlinux OBJCOPY arch/arm/boot/zImage Kernel: arch/arm/boot/zImage is ready Best regards --- Kuninori Morimoto