From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF2F4C3DA7D for ; Thu, 5 Jan 2023 09:55:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232038AbjAEJz0 (ORCPT ); Thu, 5 Jan 2023 04:55:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232186AbjAEJzO (ORCPT ); Thu, 5 Jan 2023 04:55:14 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27AE2574FC for ; Thu, 5 Jan 2023 01:55:10 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id r2so745362wrv.7 for ; Thu, 05 Jan 2023 01:55:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Z9IkS9Z7TwR5Xl6aVN2tSVjy6aS3alSYLzk3bV1tO+k=; b=eXyfz6gLw1HczVGBVIutjlzzj+KnUsqSAknuSdVl04CMKGu9DkoS0jvugaQyJCen9d NEKxckZUGkn5bNpgAsqI5AIIk/BlrKP0Vw7gmg3lERu7tmrOfj3CW140FZZJ5Cyrw933 MQcadlGjyqAR0kBygjwwoNxLxGmIzVcsBE0ZPX3INchv67X0B8FzlcR/8aNWVlqPzSLL Ekr5Qjr7PRgFMmpzHvAooskbu6weTw8PQST08ASUzQJjehfUu7Gl/2u9f7CAV39OYc5u dMfWXTouv52tJpB+vGFbSRNz9TgpVJd0oqBC1vH6qKYqiV1FPszBJBIlkRkpjT/VhYLQ 6Iug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z9IkS9Z7TwR5Xl6aVN2tSVjy6aS3alSYLzk3bV1tO+k=; b=JRZOoLyV3m0bX3Vg9a21ByYyf5cSxh45YoeWRBaaD+XJR/pFTNGi2Yehp2/TR+xrM9 IfGdaVUSjV126AQJxFGTZLUMvDh+TM6Cby9ScwV+F7tybogHXTmp/vLzRfDbfLoZJz5E hOZHh435qkljGiyrc0F+5EdllcPS/hpwfHwH3gz4r27MMJBzbGp1gSYb8p4LTKZ6cSha GjtkopA8hrx84qeMrbTClsMDgupgKdozBsquoMzY/f3rtfGAgxlS4xgh+sntfNqxExyb XGMv+lXLjQ7ATlKQr8yyNhfn0NwtOxEWM6IlCcktpvw1gqcfCjtuR/MjylNYJocm6lu2 Qksg== X-Gm-Message-State: AFqh2kq12BeEZurvWS32RZ+S9k8QWPnkbvlyeZbdr5NXRZSxsWr3zjoY 4M8H7NV2OBD29UhDnKl5jjZ08w== X-Google-Smtp-Source: AMrXdXv/u7eppdaONjDcReVjqUOgukp2sfRTn5EpcIGtoBCsW1cOUpkHGvtUR8EZprS92zX32nB8Eg== X-Received: by 2002:adf:fc01:0:b0:297:dd4a:9207 with SMTP id i1-20020adffc01000000b00297dd4a9207mr10640817wrr.10.1672912508710; Thu, 05 Jan 2023 01:55:08 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:1e12:c16d:1898:607c? ([2a01:e0a:982:cbb0:1e12:c16d:1898:607c]) by smtp.gmail.com with ESMTPSA id fc14-20020a05600c524e00b003a3442f1229sm2062350wmb.29.2023.01.05.01.55.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jan 2023 01:55:07 -0800 (PST) Message-ID: <877fc236-5f86-3853-0877-33df32689d8c@linaro.org> Date: Thu, 5 Jan 2023 10:55:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/2] dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel bindings Content-Language: en-US To: Sam Ravnborg Cc: Thierry Reding , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230103-topic-sm8550-upstream-vtdr6130-panel-v1-0-9b746b858378@linaro.org> <20230103-topic-sm8550-upstream-vtdr6130-panel-v1-1-9b746b858378@linaro.org> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/01/2023 18:57, Sam Ravnborg wrote: > Hi Neil, > > On Tue, Jan 03, 2023 at 03:22:27PM +0100, Neil Armstrong wrote: >> Document the 1080x2400 Visionox VTDR6130 AMOLED DSI Panel bindings. >> >> Signed-off-by: Neil Armstrong >> --- >> .../bindings/display/panel/visionox,vtdr6130.yaml | 53 ++++++++++++++++++++++ >> 1 file changed, 53 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml >> new file mode 100644 >> index 000000000000..49e2fd4b4e99 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml >> @@ -0,0 +1,53 @@ >> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/display/panel/visionox,vtdr6130.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Visionox VTDR6130 AMOLED DSI Panel >> + >> +maintainers: >> + - Neil Armstrong >> + >> +allOf: >> + - $ref: panel-common.yaml# >> + >> +properties: >> + compatible: >> + const: visionox,vtdr6130 >> + >> + vddio-supply: true >> + vci-supply: true >> + vdd-supply: true > These 3 looks wrong to me, as the above are not documented in panel-common. > But maybe I miss something and this is OK? It should be OK, the XXXX-supply properties are standard properties Neil > > Sam > >> + port: true >> + reset-gpios: true >> + >> +additionalProperties: false >> + >> +required: >> + - compatible >> + - vddio-supply >> + - vci-supply >> + - vdd-supply >> + - reset-gpios >> + - port >> + >> +examples: >> + - | >> + #include >> + panel { >> + compatible = "visionox,vtdr6130"; >> + >> + vddio-supply = <&vreg_l12b_1p8>; >> + vci-supply = <&vreg_l13b_3p0>; >> + vdd-supply = <&vreg_l11b_1p2>; >> + >> + reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; >> + >> + port { >> + panel0_in: endpoint { >> + remote-endpoint = <&dsi0_out>; >> + }; >> + }; >> + }; >> +... >> >> -- >> 2.34.1