From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758840AbbJISah (ORCPT ); Fri, 9 Oct 2015 14:30:37 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:34667 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757274AbbJISaf (ORCPT ); Fri, 9 Oct 2015 14:30:35 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Arnd Bergmann Cc: kbuild test robot , kbuild-all@01.org, Pablo Neira Ayuso , Patrick McHardy , Jozsef Kadlecsik , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, "David S. Miller" , netdev@vger.kernel.org References: <201510092113.o4u2vjMD%fengguang.wu@intel.com> <37905061.HAWoCKur8L@wuerfel> Date: Fri, 09 Oct 2015 13:21:54 -0500 In-Reply-To: <37905061.HAWoCKur8L@wuerfel> (Arnd Bergmann's message of "Fri, 09 Oct 2015 15:15:59 +0200") Message-ID: <877fmvzyv1.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-AID: U2FsdGVkX191LoXdD4P+WYELKJ1Z+ed0DdMAuJ/Ii8E= X-SA-Exim-Connect-IP: 67.3.201.231 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 TVD_RCVD_IP Message was received from an IP address * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa04 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa04 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Arnd Bergmann X-Spam-Relay-Country: X-Spam-Timing: total 244 ms - load_scoreonly_sql: 0.05 (0.0%), signal_user_changed: 3.0 (1.2%), b_tie_ro: 2.2 (0.9%), parse: 0.60 (0.2%), extract_message_metadata: 9 (3.8%), get_uri_detail_list: 0.84 (0.3%), tests_pri_-1000: 4.0 (1.6%), tests_pri_-950: 0.99 (0.4%), tests_pri_-900: 0.80 (0.3%), tests_pri_-400: 19 (7.6%), check_bayes: 18 (7.2%), b_tokenize: 4.6 (1.9%), b_tok_get_all: 6 (2.6%), b_comp_prob: 1.56 (0.6%), b_tok_touch_all: 3.1 (1.3%), b_finish: 0.68 (0.3%), tests_pri_0: 198 (81.1%), tests_pri_500: 7 (2.7%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH] netfilter: turn NF_HOOK into an inline function X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Wed, 24 Sep 2014 11:00:52 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > On Friday 09 October 2015 21:03:57 kbuild test robot wrote: >> ^1da177e Linus Torvalds 2005-04-16 818 cb->rt_flags &= ~DN_RT_F_IE; >> ^1da177e Linus Torvalds 2005-04-16 819 if (rt->rt_flags & RTCF_DOREDIRECT) >> ^1da177e Linus Torvalds 2005-04-16 820 cb->rt_flags |= DN_RT_F_IE; >> ^1da177e Linus Torvalds 2005-04-16 821 >> 29a26a56 Eric W. Biederman 2015-09-15 822 return NF_HOOK(NFPROTO_DECNET, NF_DN_FORWARD, >> 29a26a56 Eric W. Biederman 2015-09-15 @823 &init_net, NULL, skb, dev, skb->dev, >> 8f40b161 David S. Miller 2011-07-17 824 dn_to_neigh_output); >> ^1da177e Linus Torvalds 2005-04-16 825 >> ^1da177e Linus Torvalds 2005-04-16 826 drop: >> > > Ah, right. The 'dev' variable here is declared as > > #ifdef CONFIG_NETFILTER > struct net_device *dev = skb->dev; > #endif > > Apparently because the code produced the same warning as the ipv6 code. > > Removing the #ifdef here would make that code nicer and let us use > my patch. Alternatively we could put the same #ifdef into IPV6 and > not use the inline function. Compilers are good at removing unused variabes (SSA should guarantee this will always happen), and #ifdefs sucks. I vote for your inline. Especially as the case that is actively used and tested (CONFIG_NETFILTER) has these two functions as inline functions. Eric