mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
To: Simon Horman <horms@verge.net.au>
Cc: Zhang Rui <rui.zhang@intel.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	devicetree@vger.kernel.org, linux-sh@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Eduardo Valentin <eduardo.valentin@ti.com>,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH 05/13] thermal: rcar: Document SoC-specific bindings
Date: Fri, 18 Jul 2014 02:11:26 -0700 (PDT)	[thread overview]
Message-ID: <877g3bghfn.wl%kuninori.morimoto.gx@gmail.com> (raw)
In-Reply-To: <20140718074619.GA12613@verge.net.au>


Hi Simon

> 1. That the (in this case thermal) IP on the SoC's listed is known
>    to work with the driver using the generic (in this case
>    renesas,rcar-thermal) compatibility string.
> 
> 2. That if some incompatibility is subsequently found such that the
>    IP on SoC does function correctly using the generic compatibility
>    string or some new feature is to be enabled which is not generic
>    then it the driver should be updated with code that is triggered
>    by the SoC-specific compat string.
> 3. That Soc dts(i) files should list the more specific SoC compat string
>    followed bu the generic compat string. In this way so long as the
>    driver only matches on the generic compat string it will be used. But
>    if the driver is updated match on the SoC-specific compat string
>    then it will be used instead. In this way dtbs should be forwards
>    compatible with driver updates.
> 
>    I believe that this series includes patches to update the relevant
>    dtsi files accordingly.
> 
> In relation to verification, I believe all the SoCs listed in this patch
> are known to work with the generic compat string. And they should continue
> to work with this change because its only an documentation change. In the
> future, if a SoC specific compat string is added to the driver code then
> verification would need to occur.
> 
> From my point of view the documentation in rcar-thermal.txt is consistent
> with the documentation for other drivers that use this binding scheme
> (at least the ones that are documented :). I would not have any problems
> examples but I don't think its entirely necessary.

>From my point of view,
I have no object to adding SoC-specific compatible
string on dts(i) file.
It can be insurance for future (above 1, 2, 3).

My concern is to add "known working SoC" to documentation.
I have no objection if this listed "known working SoC" 
was matched to "SoC-specific" compatible name.
Because driver cares it specially.
And, this case, documentation should list it.

But this case, listed SoC are matched to "generic name".

> +- compatible		: "renesas,thermal-<soctype>", "renesas,rcar-thermal"
> +			  as fallback.
> +			  Examples with soctypes are:
> +			    - "renesas,thermal-r8a73a4" (R-Mobile AP6)
> +			    - "renesas,thermal-r8a7779" (R-Car H1)
> +			    - "renesas,thermal-r8a7790" (R-Car H2)
> +			    - "renesas,thermal-r8a7791" (R-Car M2)

>From my (general?) point of view,
it seems that these listed SoC doesn't match to "generic name".
I mean that driver will do something special for these SoC.
And, we will confuse if driver supports "SoC-specific" compatible name.
(which one is special ? which one is generic ?)

And, I don't want to keep updating
"generic name matched SoC" on document.

Best regards
---
Kuninori Morimoto

  reply	other threads:[~2014-07-18  9:11 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-09 12:23 [PATCH 00/13] ARM: shmobile: DT bindings and DTS updates Geert Uytterhoeven
2014-07-09 12:23 ` [PATCH 01/13] of: Add vendor prefix for Sitronix Geert Uytterhoeven
2014-07-09 12:23 ` [PATCH 02/13] irqchip: renesas-intc-irqpin: Document SoC-specific bindings Geert Uytterhoeven
2014-07-11  9:06   ` Simon Horman
2014-07-09 12:23 ` [PATCH 03/13] irqchip: renesas-irqc: Add DT binding documentation Geert Uytterhoeven
2014-07-11  9:07   ` Simon Horman
2014-07-09 12:23 ` [PATCH 04/13] mmc: tmio-mmc: Add renesas,sdhi-r8a7791 to " Geert Uytterhoeven
2014-07-09 12:31   ` Ulf Hansson
2014-07-09 12:23 ` [PATCH 05/13] thermal: rcar: Document SoC-specific bindings Geert Uytterhoeven
2014-07-11  9:13   ` Simon Horman
2014-07-15 14:48     ` Zhang Rui
2014-07-16  2:16       ` Kuninori Morimoto
2014-07-18  7:46         ` Simon Horman
2014-07-18  9:11           ` Kuninori Morimoto [this message]
2014-08-05  8:57         ` Geert Uytterhoeven
2014-08-06  0:30           ` Kuninori Morimoto
2014-08-06  7:09             ` Geert Uytterhoeven
2014-07-09 12:23 ` [PATCH 06/13] sh-pfc: Add renesas,pfc-r8a7791 to binding documentation Geert Uytterhoeven
2014-07-09 12:52   ` Laurent Pinchart
2014-07-10  9:25   ` Linus Walleij
2014-07-09 12:23 ` [PATCH 07/13] ARM: shmobile: r8a73a4 dtsi: Add SoC-specific irqc compatible property Geert Uytterhoeven
2014-07-11  9:15   ` Simon Horman
2014-07-09 12:23 ` [PATCH 08/13] ARM: shmobile: r8a73a4 dtsi: Add SoC-specific thermal " Geert Uytterhoeven
2014-07-11  9:15   ` Simon Horman
2014-07-09 12:23 ` [PATCH 09/13] ARM: shmobile: r8a7779 " Geert Uytterhoeven
2014-07-11  9:16   ` Simon Horman
2014-07-09 12:23 ` [PATCH 10/13] [RFC] ARM: dts: Add shmobile platform device tree bindings documentation Geert Uytterhoeven
2014-07-11  9:17   ` Simon Horman
2014-07-11 14:26     ` Geert Uytterhoeven
2014-07-11 15:09       ` Simon Horman
2014-07-09 12:23 ` [PATCH 11/13] [RFC] mmc: tmio-mmc: Add support for SDHI on new R-Car Gen2 SoCs Geert Uytterhoeven
2014-07-11  9:19   ` Simon Horman
2014-07-09 12:23 ` [PATCH 12/13] [RFC] thermal: rcar: Add binding docs for " Geert Uytterhoeven
2014-07-11  9:21   ` Simon Horman
2014-07-11  9:23     ` Simon Horman
2014-07-09 12:23 ` [PATCH 13/13] [RFC] irqchip: renesas-irqc: " Geert Uytterhoeven
2014-07-11  9:24   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877g3bghfn.wl%kuninori.morimoto.gx@gmail.com \
    --to=kuninori.morimoto.gx@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eduardo.valentin@ti.com \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®