mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@elte.hu>,
	Steven Rostedt <rostedt@goodmis.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Fix traceevent plugin path definitions
Date: Mon, 27 Jan 2014 14:23:58 +0900	[thread overview]
Message-ID: <877g9m6lqp.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20140122150147.GK16455@hansolo.jdub.homelinux.org> (Josh Boyer's message of "Wed, 22 Jan 2014 10:01:48 -0500")

On Wed, 22 Jan 2014 10:01:48 -0500, Josh Boyer wrote:
> The plugindir_SQ definition contains $(prefix) which is not needed
> as the $(libdir) definition already contains prefix in it.  This
> leads to the path including an extra prefix in it, e.g. /usr/usr/lib64.
>
> The -DPLUGIN_DIR defintion includes DESTDIR.  This is incorrect, as it
> sets the plugin search path to include the value of DESTDIR.  DESTDIR
> is a mechanism to install in a non-standard location such as a chroot
> or an RPM build root.  In the RPM case, this leads to the search path
> being incorrect after the resulting RPM is installed (or in some cases
> an RPM build failure).
>
> Remove both of these unnecessary inclusions.

Oops, I replied before reading this and previous discussion.. :-/ 

Anyway it looks good to me too.

Thanks,
Namhyung

      parent reply	other threads:[~2014-01-27  5:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-22 15:01 Josh Boyer
2014-01-22 15:34 ` Jiri Olsa
2014-01-25 14:23 ` [tip:perf/urgent] " tip-bot for Josh Boyer
2014-01-27  5:23 ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877g9m6lqp.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=jwboyer@fedoraproject.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®