mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Paul McKenney <paul.mckenney@us.ibm.com>
Subject: Re: [PATCH] x86: don't ever patch back to UP if we unplug cpus.
Date: Mon, 30 Jul 2012 11:38:57 +0930	[thread overview]
Message-ID: <877gtmm24m.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1343420909.3696.560.camel@sbsiddha-desk.sc.intel.com>

On Fri, 27 Jul 2012 13:28:29 -0700, Suresh Siddha <suresh.b.siddha@intel.com> wrote:
> 	if (!noreplace_smp && (num_present_cpus() == 1 || setup_max_cpus <= 1))
> 
> also, to be consistent with other checks, may be just use
> "num_possible_cpus() == 1" check instead of "setup_max_cpus <= 1".

Actually, if you specify "maxcpus=1" on the kernel command line,
you get num_possible_cpus() == 4, even though only one gets online.

So the setup_max_cpus check is in fact correct here.

Thanks!
Rusty.

  parent reply	other threads:[~2012-07-30  2:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-27  7:38 Rusty Russell
2012-07-27 20:28 ` Suresh Siddha
2012-07-30  1:15   ` Rusty Russell
2012-07-30  2:10     ` [PATCH v2] " Rusty Russell
2012-07-30 17:09       ` Suresh Siddha
2012-08-22  9:41       ` Ingo Molnar
2012-08-23  6:27         ` Rusty Russell
2012-07-30  2:08   ` Rusty Russell [this message]
2012-08-02  8:23 ` [PATCH] " Ingo Molnar
2012-08-06  7:59   ` [PATCH fixed for !SMP] " Rusty Russell
2012-08-22 10:20     ` [tip:x86/asm] x86/smp: Don' t " tip-bot for Rusty Russell
2012-08-23 10:53     ` tip-bot for Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877gtmm24m.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.mckenney@us.ibm.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome