From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11100302742 for ; Fri, 30 Jan 2026 07:06:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769756797; cv=none; b=qjblqHOfJhV1mmF9lpPpHTSLcqFbdx/ovN26mjsnbM4BDdky11Bx6oaX4+ByZLKAyOcYDeIk8sAB7oR4ETl0CHdswsOZ/zvDABNk4AyC/k793uitzkrNzYKpOTEe2fNmUB5bMtmL1hyhfY8lVfwI9+nT9CZObamvSHRsR9qq9bY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769756797; c=relaxed/simple; bh=s0CHURudGzYLC+hzi+ZJIPjJMX3Kvv/uYTN/tO6I6ng=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kWnuiD1Ta9EmTmZzYd9H282qMqLuidTsSZSLyCsKveux28tt1XeC7tJ1tFJ2elGPs0u7vJx4TkspHRSdTgQvZVYUcS0iQbgcsX6JC8BBvLPrkmxaQMccMvgGVsvrjd1H7e32eXPyZqI1hwdCA1TpPHaduAiLvuIp8F8aTrqc9R4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=USwK9gMy; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="USwK9gMy" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42fb2314f52so1066187f8f.0 for ; Thu, 29 Jan 2026 23:06:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1769756794; x=1770361594; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JnG6xg4PsOUKKQ1jkLAF2YDjC5bopGJAX+gen6DcvE0=; b=USwK9gMyjJdSiQJboEKwAL2UYXknXXUWleKrptdNAfWHU0eLn2fWGcBRI7POdl+Yb7 CWHbq81Hel/qv6Pb6iUc5pawbX470pjs7moiyoRHeFVrN9adxatQkM7S0Zvv1u8VCLBn YZEyKzqLX6xCRa8quFV9e9oYEfg1n8rk3e1XXp0SiJzz5lLahfc177QUwBmq9pbqeunv cz3hr9AxEA05ojZs07pTUqMiP9tdZSzAjlLnk2bHaOT+WsOyL5NAk+omzvcOpHG6FVhz kfMuFiCY7pSpD4z0+398h9dpkuXCBbqK2T4wpNzMJdE0fTGSpsXKfgixsOUlw+4j5+5k qK1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769756794; x=1770361594; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JnG6xg4PsOUKKQ1jkLAF2YDjC5bopGJAX+gen6DcvE0=; b=NcOJ6rLpjbGx0MmnrLnAKoPJxnmc7wJgLTgBVDO8uJDRA601ZRnIWrsydM1DlsBwgo oK4MKpUG3p7JG2r9aw3aKyvp0uyh4I11qfD/nx2/5V/1ulYlqlclRhzlf+khZKlPkDjL w2ZWukoSR3pWBNOtMYICYCxByMuYY+bdgsLDj+mFrkywRGJYD/2kCj/V6nPUaDNZljuL Sf9r0qS37dp9p/Bj5qmYWebwA2moE0Eiy0ACWaWDd0Y8GjOZrlWJMFw7dMR2fei2TWep 6T12INoeZNiptzLzBCpkcvDaEqI2XutmbSuO0FXiqS4ShibhhNIFbQvzbItf4VD3+LSh EtdQ== X-Forwarded-Encrypted: i=1; AJvYcCUtmzfd/Fn0DNZUFudiPgvwIVEc4oosq7JJzsLWOB1YPqqWVQXGWwC3Yt9rgJnKDPnmIVAOH/V2wb9CsOg=@vger.kernel.org X-Gm-Message-State: AOJu0YzbHG1wPrpa9W+x4scO805MzP+OW61Lzgv2SHfyE0o+ws+0vAFs YpG0Dd2sWn/S1GSgZKpjo6mtqnv4Pd7mUPv59sL9hHGC7r86CTmUnvjx1k+Aj3jxIpk= X-Gm-Gg: AZuq6aL++cm8ZRXPVz2UCc5X8R8ZX6leQUyKLOA3KRDJTkot033hv5RSY13Z7nZ7Wzr Gb3NqWzO4a9tD/2wqTwAvYMFu5mloa8TBqcFA1G5bB70quI3S/pEmV91tSXt4id5kbQ/NLZb1Dm bn/S6L1CsuTgrXwWocFEY0E5zZelBgwEaWUDGjzfAh8ZVP8pJiU215Pp6e1vnmYEopyK5Vwtyrm t1kA9PBMaAXr1Y2F52yN2aCg/ypYqNKWYiCgF1nWfCWdF0ySWHoMTqSm9tj0yP0petn6qUV2lUh S+joHup0Ne5zloVd87EfMl14oc140nva11XGvGeR2tCXRe6wQwpGR+4FiAWiYzUegqnwsNHDIkO AjgdM5ZUxuOVy299cSNdaOxSeRHLrkLSWQt/6AjBXju1HQbX9uDwc7t4QYfbHmwXwKHyLcB2duL d9yLGBVHxD7o3iE8ZCwg== X-Received: by 2002:a05:6000:40da:b0:431:8f8:7f1e with SMTP id ffacd0b85a97d-435f3aaf81cmr2905850f8f.48.1769756794284; Thu, 29 Jan 2026 23:06:34 -0800 (PST) Received: from [10.31.13.216] ([82.77.28.160]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e1353ac2sm21442766f8f.38.2026.01.29.23.06.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 23:06:33 -0800 (PST) Message-ID: <878697e8-9770-4707-83c8-e8c3834c4447@tuxon.dev> Date: Fri, 30 Jan 2026 09:06:31 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 11/31] clk: at91: clk-usb: add support for clk_parent_data To: ryan.wanner@microchip.com, mturquette@baylibre.com, sboyd@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, bmasney@redhat.com, alexander.sverdlin@gmail.com, varshini.rajendran@microchip.com Cc: cristian.birsan@microchip.com, balamanikandan.gunasundar@microchip.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <37dfe16abee98a6b768fbb3b82c0b8cd23bb6e44.1768512290.git.ryan.wanner@microchip.com> Content-Language: en-US From: claudiu beznea In-Reply-To: <37dfe16abee98a6b768fbb3b82c0b8cd23bb6e44.1768512290.git.ryan.wanner@microchip.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Ryan, On 1/16/26 22:07, ryan.wanner@microchip.com wrote: > @@ -818,18 +817,22 @@ static void __init sam9x7_pmc_setup(struct device_node *np) > switch (sam9x7_plls[i][j].p) { > case SAM9X7_PLL_PARENT_MAINCK: > parent_data[0] = AT91_CLK_PD_NAME("mainck"); > - hw = sam9x7_pmc->chws[PMC_MAIN]; > + parent_rate = clk_hw_get_rate(sam9x7_pmc->chws[PMC_MAIN]); > break; > case SAM9X7_PLL_PARENT_MAIN_XTAL: > + struct clk *main_xtal; > + main_xtal = of_clk_get_by_name(np, main_xtal_name); > + if (IS_ERR(main_xtal)) > + goto err_free; > parent_data[0] = AT91_CLK_PD_NAME(main_xtal_name); > - hw = main_xtal_hw; > + parent_rate = clk_get_rate(main_xtal); > + clk_put(main_xtal); > break; Could you please let me know why is this change related to USB? It looks to me that it should go in a different patch. Same for the similar changes done on sama7d65.c. Sorry for not noticing it previously. The rest LGTM. Thank you, Claudiu