mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Jonas Karlman <jonas@kwiboo.se>
Cc: John Clark <inindev@gmail.com>,
	heiko@sntech.de, robh@kernel.org, conor+dt@kernel.org,
	detlev.casanova@collabora.com, linux-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: Add Luckfox Omni3576 Board support
Date: Sun, 4 May 2025 16:12:20 +0200	[thread overview]
Message-ID: <87892840-bdbf-43d4-bd93-cb98f5e1c672@lunn.ch> (raw)
In-Reply-To: <bb171ae2-c495-49a3-a7eb-a4b865e54199@kwiboo.se>

> > +&gmac0 {
> > +	clock_in_out = "output";
> > +	phy-handle = <&rgmii_phy0>;
> > +	phy-mode = "rgmii-rxid";
> 
> See Andrew's remark on v1 of this patch.

Hi John

If you have questions, please ask. It is not a good idea to silently
ignore reviewers comments. Either do something about it, ask
questions, or politely argue why the reviewer is wrong, because
sometimes we are.

> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&eth0m0_miim
> > +		     &eth0m0_tx_bus2
> > +		     &eth0m0_rx_bus2
> > +		     &eth0m0_rgmii_clk
> > +		     &eth0m0_rgmii_bus
> > +		     &ethm0_clk0_25m_out>;
> > +	snps,reset-gpio = <&gpio2 RK_PB3 GPIO_ACTIVE_LOW>;
> > +	snps,reset-active-low;
> > +	snps,reset-delays-us = <0 20000 100000>;
> 
> The snps,reset- props are depracated, please move to reset props in the
> Ethernet PHY node.

FYI: snps,dwmac.yaml says:

snps,reset-gpio:
    deprecated: true
    maxItems: 1
    description:
      PHY Reset GPIO

Anything with 'deprecated: true' you should not be using in new DT
blobs. Don't blindly copy vendor DT, you need to verify it is up to
Mainline quality, and if not, bring it up to Mainline quality.

> > +	tx_delay = <0x20>;

This property probably plays a role in the issue with phy-mode.

arch/arm64/boot/dts/rockchip$ grep "rgmii-id" *
rk3328-orangepi-r1-plus-lts.dts:	phy-mode = "rgmii-id";
rk3566-bigtreetech-cb2.dtsi:	phy-mode = "rgmii-id";
rk3566-nanopi-r3s.dts:	phy-mode = "rgmii-id";
rk3566-odroid-m1s.dts:	phy-mode = "rgmii-id";
rk3566-orangepi-3b.dtsi:	phy-mode = "rgmii-id";
rk3566-radxa-zero-3e.dts:	phy-mode = "rgmii-id";
rk3566-rock-3c.dts:	phy-mode = "rgmii-id";
rk3568-evb1-v10.dts:	phy-mode = "rgmii-id";
rk3568-evb1-v10.dts:	phy-mode = "rgmii-id";
...
etc.

You might be able to learn something from these.

	Andrew

  reply	other threads:[~2025-05-04 14:12 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-02 20:55 [PATCH v1 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576 John Clark
2025-05-02 20:55 ` [PATCH v1 1/3] dt-bindings: vendor-prefixes: Add luckfox prefix John Clark
2025-05-02 20:55 ` [PATCH v1 2/3] dt-bindings: arm: rockchip: Add Luckfox Omni3576 board John Clark
2025-05-02 20:55 ` [PATCH v1 3/3] arm64: dts: rockchip: Add Luckfox Omni3576 Carrier Board with Core3576 Module John Clark
2025-05-02 21:51   ` Andrew Lunn
2025-05-03 23:39 ` [PATCH v1 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576 Nicolas Frattaroli
2025-05-04  8:08   ` Heiko Stübner
2025-05-04 10:24 ` [PATCH v2 " John Clark
2025-05-04 10:24   ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add luckfox prefix John Clark
2025-05-04 17:53     ` Krzysztof Kozlowski
2025-05-04 10:24   ` [PATCH v2 2/3] dt-bindings: arm: rockchip: Add Luckfox Omni3576 board John Clark
2025-05-04 17:54     ` Krzysztof Kozlowski
2025-05-04 10:24   ` [PATCH v2 3/3] arm64: dts: rockchip: Add Luckfox Omni3576 Board support John Clark
2025-05-04 13:26     ` Jonas Karlman
2025-05-04 14:12       ` Andrew Lunn [this message]
2025-05-04 21:02         ` John Clark
2025-05-04 23:01           ` Andrew Lunn
2025-05-04 23:06             ` John Clark
2025-05-04 23:41             ` John Clark
2025-05-05  0:45               ` Andrew Lunn
2025-05-05  0:52                 ` John Clark
2025-05-05 13:22                   ` Diederik de Haas
2025-05-05 14:01                     ` Andrew Lunn
2025-05-05 10:36                 ` John Clark
2025-05-05 12:38                   ` Andrew Lunn
2025-05-05 12:14     ` Jonas Karlman
2025-05-05 14:44   ` [PATCH v2 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576 Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87892840-bdbf-43d4-bd93-cb98f5e1c672@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=detlev.casanova@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=inindev@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®