From: Takashi Iwai <tiwai@suse.de>
To: Alyandra SigmabetJir <alyandra5b@gmail.com>
Cc: HyeongJun An <sammiee5311@gmail.com>,
Takashi Iwai <tiwai@suse.de>,
perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ALSA: ump: clear stale RPN selector on NRPN change
Date: Sun, 08 Nov 2026 11:47:43 +0100 [thread overview]
Message-ID: <878q33y4z4.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAJYQYHxrpmBPiyMiS2oK8eugUMR=KFmf9D5jwLdoYUYQgKkXjw@mail.gmail.com>
On Sun, 08 Nov 2026 07:07:08 +0100,
Alyandra SigmabetJir wrote:
>
>
> Hi HyeongJun,
>
> Thank you for bringing up these related cases in the earlier discussion. I
> also appreciate you taking the time to work on the additional patches.
>
> Thank you for clarifying the situation and sharing the details.I appreciate
> your help and the work you've already put into this.
Could you guys cooperate and organize a single fix series? That'd be
nicer at merge.
Also, about the unit test: I'm not much against kunit, but my gut
feeling is that selftest would be more flexible (and less changes in
the core code itself). If that's feasible, let's go in that way.
Otherwise we can take the kunit change. But maybe it's cleaner to
move the test code into another file.
thanks,
Takashi
>
> Sincerely,
> Alyandra
>
> Pada Sab, 7 Nov 2026 21.29, HyeongJun An <sammiee5311@gmail.com> menulis:
>
> Hello Takashi,
>
> Thanks for adding me, and thanks Alyandra for the patches. Yes, this is
> one of the cases from that thread.
>
> I have patches for the other cases discussed there. They keep the
> RPN/NRPN selection after a send and clear only the data, drop data when
> nothing is selected, and handle a Null NRPN like a Null RPN. They also
> need the same selector change as this patch.
>
> I can send them on top of Alyandra's patches, or as one series that
> includes the selector change, whichever you prefer.
>
> Best regards,
> HyeongJun An
>
prev parent reply other threads:[~2026-11-08 10:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 11:10 Alyandra Zahran Nadhir
2026-11-07 11:10 ` [PATCH 2/2] ALSA: ump: clear stale selectors in sequencer conversion Alyandra Zahran Nadhir
2026-11-07 13:51 ` [PATCH 1/2] ALSA: ump: clear stale RPN selector on NRPN change Takashi Iwai
2026-11-07 14:29 ` HyeongJun An
[not found] ` <CAJYQYHxrpmBPiyMiS2oK8eugUMR=KFmf9D5jwLdoYUYQgKkXjw@mail.gmail.com>
2026-11-08 10:47 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878q33y4z4.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alyandra5b@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sammiee5311@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®