Re: [PATCH v5] uniwill: Add support for MECHREVO WUJIE Series 15 X Pro

[Donjuanplatinum <donplat@barrensea.org>]

Armin Wolf <W_Armin@gmx.de> writes:

> Am 11.10.26 um 10:14 schrieb Donjuanplatinum:
>


> Does the OEM control center for Windows support battery charging
> modes? If yes then you should also select
> UNIWILL_FEATURE_BATTERY_CHARGE_MODES.
>
> Other than that the patch looks fine to me, but i would be very happy
> if you could rebase it on the current for-next branch.
>
> Thanks, Armin Wolf

Hi Armin, I think some of my previous replies may have been missed. I
have added and tested the battery charging mode:

> > Can you check if UNIWILL_FEATURE_BATTERY_CHARGE_MODES also works on
> > your device?  Please note that the embedded controller will still
> > report to charge the battery to 100%, so this is not a reliable
> > indicator. Do you know if the Windows OEM app provides such a
> > setting on this device?
> >
> > Thanks, Armin Wolf
> >

> I also checked the battery charge modes in the Windows OEM
> application. The OEM application provides this setting.

> Additionally, I used the interfaces exposed by the OEM's
> ACPIDriverDll.dll to test the three charge modes and confirmed that
> their behavior matches the current implementation in the Uniwill
> driver.

This is the previous disscuss:
https://lore.kernel.org/platform-driver-x86/c8cb27ab-e5de-4a86-ad09-6610905e74b8@gmx.de/T/#mf80e6c3fdad4eb3af835504c0e512df66c474c52



> Other than that the patch looks fine to me, but i would be very happy if you
> could rebase it on the current for-next branch.

I put the rebased patch here,it now base the for-next:

From c45bac93447a52dd2e4a76395202a13c6d91763c Mon Sep 17 00:00:00 2001
From: Donjuanplatinum <donplat@barrensea.org>
Date: Mon, 2 Nov 2026 11:03:25 +0800
Subject: [PATCH] platform/x86: uniwill-laptop: Add support for MECHREVO WUJIE
 Series 15 X Pro

Add support for the MECHREVO WUJIE Series 15 X Pro (WUJIE
Series-X5SP4NAG).

Signed-off-by: Yifei Yao <donplat@barrensea.org>
---
 drivers/platform/x86/uniwill/uniwill-acpi.c | 22 +++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/drivers/platform/x86/uniwill/uniwill-acpi.c b/drivers/platform/x86/uniwill/uniwill-acpi.c
index f62d59f29676..d49be1caea50 100644
--- a/drivers/platform/x86/uniwill/uniwill-acpi.c
+++ b/drivers/platform/x86/uniwill/uniwill-acpi.c
@@ -2715,6 +2715,20 @@ static struct platform_driver uniwill_driver = {
 	.shutdown = uniwill_shutdown,
 };
 
+static struct uniwill_device_descriptor series_x5sp4nag_descriptor __initdata = {
+	.features = UNIWILL_FEATURE_FN_LOCK |
+		    UNIWILL_FEATURE_SUPER_KEY |
+		    UNIWILL_FEATURE_CPU_TEMP |
+		    UNIWILL_FEATURE_PRIMARY_FAN |
+		    UNIWILL_FEATURE_SECONDARY_FAN |
+	            UNIWILL_FEATURE_BATTERY_CHARGE_MODES |
+		    UNIWILL_FEATURE_KEYBOARD_BACKLIGHT |
+		    UNIWILL_FEATURE_AC_AUTO_BOOT |
+		    UNIWILL_FEATURE_USB_POWERSHARE,
+	.kbd_led_single_color = false,
+	.kbd_led_max_brightness = 4,
+};
+
 static struct uniwill_device_descriptor machenike_l16p_descriptor __initdata = {
 	.features = UNIWILL_FEATURE_FN_LOCK |
 		    UNIWILL_FEATURE_SUPER_KEY |
@@ -3075,6 +3089,14 @@ static const struct dmi_system_id uniwill_dmi_table[] __initconst = {
 		},
 		.driver_data = &x4sp4nal_descriptor,
 	},
+	{
+		.ident = "MECHREVO WUJIE Series 15 X Pro",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "MECHREVO"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "WUJIE Series-X5SP4NAG"),
+		},
+		.driver_data = &series_x5sp4nag_descriptor,
+	},
 	{
 		.ident = "MACHENIKE L16 Pro",
 		.matches = {
-- 
2.56.0