From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 949343603E9; Tue, 11 Aug 2026 06:16:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786428977; cv=none; b=hQ9YH+0lp246wXWJYIcnC7qwEgQr75rynbxFMnZ+E/WFarle3uzhAb2sbxvQq7sPL7Ag8F2Uh79WVpRUqGEr70mAQC/Ti7ObtMlA69YCQA8qF5jXzOTIk1MXu2i4ABA/UZk1ctRVNdevZSORaotLflxW+Ih2jkh5SUHArrTj9II= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786428977; c=relaxed/simple; bh=HxcpNbhlMRcggN14z8PLMSrNKeC542q8SI45PJzk208=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=kxlDAq32GveD5KKtlbLyBPQQoHuW6GruTsNqUbsD+CMJfpWhq1QtyP8JXJn+NN1FYIisU+ty+3sHz77oDaMKtpq1RK0+a9JVrMIaoJZkcrU37lHEm1ZEjXVw+G1Z98m9vIC+HtnKAgMgi5lNmxyw+DHVhI20LjzXBPZkojyQVu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=C0IfrOsk; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=+u6BbYj+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=RpQr8tRT; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=b4pIE1au; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="C0IfrOsk"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="+u6BbYj+"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="RpQr8tRT"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="b4pIE1au" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 93DA0818A0; Tue, 11 Aug 2026 06:16:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786428970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t1bx7BFB+UZkrxotKPC/DFhVVbD5exlifYlPbT0gDGo=; b=C0IfrOsk8Ot+uPJoTJG4Di2/S7j1KydjOM+bgHNp9/zrp7DexQCXTvZYX+aKlAVScX3hq3 nemXUqrVHXDRLX/rGoNRdQcFrQ2WmSRR29pmbjDr0bbfEG8SjDmKVW8QghvjE9Sl2+sjD/ hSPH67OJCbFo9uD5HqMaUkYaif+EM1g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786428970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t1bx7BFB+UZkrxotKPC/DFhVVbD5exlifYlPbT0gDGo=; b=+u6BbYj+EFoMFaNZjgbQDjcS7l4FThecFBel9W6jaVrtzESfoDj4RvOLsm5CNjlPLu1yvb nc+tCIg63ctkDoBQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786428966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t1bx7BFB+UZkrxotKPC/DFhVVbD5exlifYlPbT0gDGo=; b=RpQr8tRTYfIONa+5ktj8RRMEV3KeOXVJYGCqltF1xs2oE5+LAkb7MD5QXA9I9jAePBKuo1 5cNeKqzAAcl/aocg9jRd705L+kWdFBOABAkJNpX4yjDqevFqPJsn3duFQkhA2mMGaA3O73 AcogLiBkog/fuxIJFzDi7HfgVBEkIJ8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786428966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t1bx7BFB+UZkrxotKPC/DFhVVbD5exlifYlPbT0gDGo=; b=b4pIE1auAOJ/8/qrOTKZoyHaX/hZV39b40FAQb7jVxO8qMnCqnSGZvnoNWxW1wUm0inWxy T8RTklZlMsb5siBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 61074779B2; Tue, 11 Aug 2026 06:16:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4MqGFSa+empYQQAAD6G6ig (envelope-from ); Tue, 11 Aug 2026 06:16:06 +0000 Date: Tue, 11 Aug 2026 08:16:06 +0200 Message-ID: <878q6db2s9.wl-tiwai@suse.de> From: Takashi Iwai To: Rosen Penev Cc: linux-sound@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH] sound: pci: mixart: use managed resources for PCI and DMA allocations In-Reply-To: <20260811042241.54317-1-rosenp@gmail.com> References: <20260811042241.54317-1-rosenp@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -3.30 X-Spam-Level: X-Spam-Flag: NO X-Spamd-Result: default: False [-3.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_SOME(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo] On Tue, 11 Aug 2026 06:22:41 +0200, Rosen Penev wrote: > > Convert the Digigram miXart driver to use managed (devm_) resources > for PCI device management, IRQ allocation, memory mapping, and DMA > buffer allocation. This simplifies error handling paths and reduces > the risk of resource leaks. > > - Use pcim_enable_device() and pcim_iomap_region() for managed PCI > resource handling > - Use devm_kzalloc() for manager structure allocation > - Use devm_request_threaded_irq() for IRQ allocation > - Use snd_devm_card_new() for sound card creation > - Use snd_devm_alloc_pages() for DMA buffer allocation > - Simplify snd_mixart_free() to only handle mailbox shutdown and > board reset since other resources are now auto-released > > Clean up trailing whitespace on touched lines. > > Signed-off-by: Rosen Penev I guess this is only compile-tested? This driver is somewhat special, and it composes of multiple sound-card objects per device, hence you can't use devres under the card. thanks, Takashi