mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: WenTao Liang <vulab@iscas.ac.cn>
Cc: perex@perex.cz, tiwai@suse.com, ramiserifpersia@gmail.com,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] fix: sound/usb/usx2y: capture_urb_complete: redundant usb_anchor_urb corrupts anchor list on each resubmission
Date: Mon, 29 Jun 2026 12:19:02 +0200	[thread overview]
Message-ID: <878q7xr6nd.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260627042949.61767-1-vulab@iscas.ac.cn>

On Sat, 27 Jun 2026 06:29:49 +0200,
WenTao Liang wrote:
> 
> In capture_urb_complete(), usb_anchor_urb() is called on every
> completion callback, but the URB is already anchored from the
> initial submission in tascam_trigger_start(). Each redundant call
> corrupts the anchor's doubly-linked list and inflates the URB
> refcount. When usb_kill_anchored_urbs() traverses the list during
> stream stop / suspend / disconnect, the corrupted list leads to
> use-after-free.
> 
> Remove the redundant usb_anchor_urb() from the resubmit path.
> 
> Cc: stable@vger.kernel.org
> Fixes: c1bb0c13e430 ("ALSA: usb-audio: us144mkii: Implement audio capture and decoding")
> Signed-off-by: WenTao Liang <vulab@iscas.ac.cn>

Applied now.  But, at the next time, please try to adjust the subject
prefix; for sound/usb, it's "ALSA:"


thanks,

Takashi

      reply	other threads:[~2026-06-29 10:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-27  4:29 WenTao Liang
2026-06-29 10:19 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878q7xr6nd.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=ramiserifpersia@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®