From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C30802737F8 for ; Wed, 17 Dec 2025 16:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765990240; cv=none; b=aOG3iLIWrdHLXGliwuowXn7D4ZPkBnS0xhhx9eRugzindqbOhriGFaaiHCv9YJcQuV3uoCB1ckIfC/3GH3sFeRd9rqeXe2jrN2fihOZ7xbGmPj2yrvZr2HdpLDMWpvDaq5MibCAaG/xYWtbShb08sTO5q4fCyqyjwATpa+EFRwQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765990240; c=relaxed/simple; bh=8ew3OGqAHDd9DlzCIOvVKQ1X4MAmaiZDbi6PJORY7z0=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References: MIME-version:Content-type; b=AsFwOKtKqMAmbVsm8AxDyCtbMSa3ZbnTzN96Q2wbLKQwlVTQAVKNvcjf9p5aPak+zNG9QbGJlgwJLwF0mcowiXIkajaB3YiLvMXQI+7S3yXLGdRkZESkXi4pRhwZOldRmtlmw0gbZ4XVDcDfAwt2RIIKzu5WQVKWywbMQ053BLY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PF2S+O0o; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PF2S+O0o" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2a09d981507so6675925ad.1 for ; Wed, 17 Dec 2025 08:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765990233; x=1766595033; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:message-id:date :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=PAsD2vPOWvukoB2byMq+XQ93o9WOXXcOD9dnTih7p44=; b=PF2S+O0ouN/Rwfi41MsoyAhVfFRtvNo7p8++MTGn6TlFrJ5xAHZf+zEgkfCVbea05N mW0pNnHTXqEaqRpB0ZzlZ0U/CoQ1vHLT/a8lkXHrY/STILFlV+fSYmN6x33dhRgjOAi/ BnrcRFLKUAea3ElStCcsqHIhFFjA53u5VshZm4Qh0pTIM8nh1kseWDYcDZXRbo3FnNCj MewnwY6T6yYUFKf5BMikChteovPxSYjC29+ukC8LDdeE4WDtteepEZZ0gszLol3Qr6FK iA6GO6znftrdcFdESXNAQtXYVSbd97XNp8hUCPl3tb7GLDEI5SPgvAynalNd3fUXphYw /lMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765990233; x=1766595033; h=content-transfer-encoding:mime-version:references:message-id:date :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PAsD2vPOWvukoB2byMq+XQ93o9WOXXcOD9dnTih7p44=; b=Sv9AixKOrU02kI4U5Zpo4AZeNi/V3eIu0Rb+wK5V+gQolhZP8oMnnQ4gLCYFmuiHta MZwEn6d9GQdSdWKruDCz5+N80V7KKgAkOiunAewKZNRjZgjkckcqRK8/RgdcLkX4LsCv lBnCqlRIPdX9CabtG3OaJQKpfjAE8Rv8psIlUptSNJISrGVlO84lhotYo4bvX5oR7FB3 qS805QK8P2FBy520QlBHm2OVvRc11/zPNwdTJ+8ykhoGLsQmhRnHZZwaS0Crdef56vpE TuQCUSXEMXUehcpRI+qODWoUNXpPIyItzYv/uaOyef31RqTt7o9n2/XqXuKT3FN2JN3A PwJQ== X-Gm-Message-State: AOJu0YzZPdGH99IQutxhVdq2BWWnlktc9plgcwvXh7jQEq+317nT/R+6 hmS//RfjlOfp0c0959KYL5vBcT9meB8wsg+GqYOtHlKK13DgVXq2otuH X-Gm-Gg: AY/fxX7+ymE5iEAk6WsBtGBCrolNH6yYWQPyDzjeq/KVzeHEo7TrdOAZt9byPSX6CoY ZjGKxmsBhi5cNcGL1oLnRxMXYCPBDhSBa/jlCEQe2Kua8OLdfleERiQ2gkE/zrIhqZ8omtrG9F+ k7RbF9rSKAmKr7QAJfyP09zvEDtCFwMB7j3OcY7H+JlnlPJgS2qmetCkuLbvbtW9WfgA2qkVxqF JlsTEBk3wZXrjrlxIQPONR9Ub08TYVRTIusAE3/5YxmnteuO0PIEZKlCv8RgHRO/YDbVWcKlEEP hwPfva8uuJ/WDZwPsNQVPMEL0StNAyCq2uks0n43gCIucCN4M/vqH4O0pyaXQkch5zIqXDWVP59 xMwuKuisRe5GrISp5nX2Tehx+BJD1yShNDQkBFdCZLMJAMxKxS+3bj6vC2iYNppLAoAKl746qIk tOGm/+9w== X-Google-Smtp-Source: AGHT+IEVED3e+KdGXZXVcYIldELMqcKzBvn3EudeqgTtF1rVnKCzdaDs50jLdVQ3ZTdPF69nS2yCCg== X-Received: by 2002:a17:902:d542:b0:2a0:b467:a7d0 with SMTP id d9443c01a7336-2a2cab16184mr316675ad.16.1765990232877; Wed, 17 Dec 2025 08:50:32 -0800 (PST) Received: from dw-tp ([171.76.225.126]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29f177ff327sm172094595ad.101.2025.12.17.08.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 08:50:32 -0800 (PST) From: Ritesh Harjani (IBM) To: Kevin Brodsky , Andrew Morton Cc: linux-kernel@vger.kernel.org, Ryan Roberts , linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Kevin Brodsky Subject: Re: [PATCH] powerpc/mm: export symbols for lazy_mmu_mode KUnit tests In-Reply-To: <20251217163812.2633648-1-kevin.brodsky@arm.com> Date: Wed, 17 Dec 2025 22:15:16 +0530 Message-ID: <878qf1kqg3.ritesh.list@gmail.com> References: <20251216201403.4647a4f9861d3122ee9e90d7@linux-foundation.org> <20251217163812.2633648-1-kevin.brodsky@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Kevin Brodsky writes: > Upcoming KUnit tests will call lazy_mmu_mode_{enable,disable}. > These tests may be built as a module, and because of inlining this > means that symbols referenced by arch_{enter,leave}_lazy_mmu_mode > need to be exported. > > Suggested-by: Ryan Roberts > Suggested-by: Ritesh Harjani (IBM) > Signed-off-by: Kevin Brodsky > --- Hi Kevin, I guess, this can give following errors: ../arch/powerpc/mm/book3s64/hash_tlb.c:33:1: error: data definition has no type or storage class [-Werror] 33 | EXPORT_SYMBOL_IF_KUNIT(ppc64_tlb_batch); /* For lazy_mmu_mode KUnit tests */ | ^~~~~~~~~~~~~~~~~~~~~~ ../arch/powerpc/mm/book3s64/hash_tlb.c:33:1: error: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_IF_KUNIT’ [-Werror=implicit-int] ../arch/powerpc/mm/book3s64/hash_tlb.c:33:1: error: parameter names (without types) in function declaration [-Werror] ../arch/powerpc/mm/book3s64/hash_tlb.c:158:1: error: data definition has no type or storage class [-Werror] 158 | EXPORT_SYMBOL_IF_KUNIT(__flush_tlb_pending); /* For lazy_mmu_mode KUnit tests */ | ^~~~~~~~~~~~~~~~~~~~~~ ../arch/powerpc/mm/book3s64/hash_tlb.c:158:1: error: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_IF_KUNIT’ [-Werror=implicit-int] ../arch/powerpc/mm/book3s64/hash_tlb.c:158:1: error: parameter names (without types) in function declaration [-Werror] AR init/built-in.a cc1: all warnings being treated as errors make[6]: *** [../scripts/Makefile.build:287: arch/powerpc/mm/book3s64/hash_tlb.o] Error 1 make[5]: *** [../scripts/Makefile.build:556: arch/powerpc/mm/book3s64] Error 2 IMO, we will need the following header in hash_tlb.c +#include -ritesh > > Andrew, please add this patch just before the last patch in the series > ("mm: Add basic tests for lazy_mmu"). Thanks! > --- > arch/powerpc/mm/book3s64/hash_tlb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/mm/book3s64/hash_tlb.c b/arch/powerpc/mm/book3s64/hash_tlb.c > index fbdeb8981ae7..9e622519a423 100644 > --- a/arch/powerpc/mm/book3s64/hash_tlb.c > +++ b/arch/powerpc/mm/book3s64/hash_tlb.c > @@ -30,6 +30,7 @@ > #include > > DEFINE_PER_CPU(struct ppc64_tlb_batch, ppc64_tlb_batch); > +EXPORT_SYMBOL_IF_KUNIT(ppc64_tlb_batch); /* For lazy_mmu_mode KUnit tests */ > > /* > * A linux PTE was changed and the corresponding hash table entry > @@ -154,6 +155,7 @@ void __flush_tlb_pending(struct ppc64_tlb_batch *batch) > flush_hash_range(i, local); > batch->index = 0; > } > +EXPORT_SYMBOL_IF_KUNIT(__flush_tlb_pending); /* For lazy_mmu_mode KUnit tests */ > > void hash__tlb_flush(struct mmu_gather *tlb) > { > > base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 > -- > 2.51.2