From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6F91C77B61 for ; Mon, 10 Apr 2023 16:39:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230281AbjDJQjU (ORCPT ); Mon, 10 Apr 2023 12:39:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229982AbjDJQjS (ORCPT ); Mon, 10 Apr 2023 12:39:18 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA10F1729 for ; Mon, 10 Apr 2023 09:39:17 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8D77A1FDDB; Mon, 10 Apr 2023 16:39:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681144755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bPJMlcg/GJ3Z5XHbPwTY0KXJ3aePcjHBDKXnTXpIimo=; b=O94UpZTaW50mMBpRSlmfcKPiKV2HGah10vUUU6uRhK7U+cLHBx7jjHA1OKutXOfwsPastU FOlqvuQUaoH0fN0xmU4idI4oN02JvqNi9AgPogi9EDFy/kkyE5TMAMDdSSnD0Gj6S2N4/B 4NRr/oHjvXh91io9SRTrqLd4uk84Qy8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681144755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bPJMlcg/GJ3Z5XHbPwTY0KXJ3aePcjHBDKXnTXpIimo=; b=R7tNfHcs95OJK50y8TwpM0okt5LgoxUM9auio/So5aH6eOjF2yD9nTLh0LTJGO0wyHCWwp I+cC1JjY6Wn58LCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 61855138F0; Mon, 10 Apr 2023 16:39:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id p0HgFrM7NGTGfwAAMHmgww (envelope-from ); Mon, 10 Apr 2023 16:39:15 +0000 Date: Mon, 10 Apr 2023 18:39:14 +0200 Message-ID: <878rez4rpp.wl-tiwai@suse.de> From: Takashi Iwai To: Cem Kaya Cc: "perex@perex.cz" , "tiwai@suse.com" , "mario.limonciello@amd.com" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that internal DMIC works. In-Reply-To: <38108AA1-01F5-4C48-A03E-73E9CAC3E8CF@getmailspring.com> References: <38108AA1-01F5-4C48-A03E-73E9CAC3E8CF@getmailspring.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Apr 2023 18:03:36 +0200, Cem Kaya wrote: > > > From 972ad712cfda9453a720b73c645601db23d708c6 Mon Sep 17 00:00:00 2001 > From: Cem Kaya > Date: Sat, 8 Apr 2023 16:20:42 +0200 > Subject: [PATCH v3] Add Dell G15 5525 Ryzen Edition to quirks list for acp6x > so > that internal DMIC works. > Signed-off-by: Cem Kaya > Commit: Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that > internal mic works. > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217155 Looks better, but still a few things to be correctly formatted. The subject line needs the proper prefix, depending on the subsystem. In your case, put "ASoC: amd:", for example. Also, the subject line should be concise. The patch description is no such a tag like "Commit:", but it should be filled in the commit log. This can be as long as you like, but put the line breaks appropriately. The Link and Signed-off-by tags follow after the patch description with a blank line. In your case, it'd be worth to put Cc-to-stable, too. So, it should be like: -- 8< -- From: Cem Kaya Subject: [PATCH v3] ASoC: amd: Add Dell G15 5525 to quirks list for internal DMIC Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that internal mic works. Link: https://bugzilla.kernel.org/show_bug.cgi?id=217155 Cc: Signed-off-by: Cem Kaya -- 8< -- ..., and get the right maintainer via scripts/get_maintainer.pl, put them to Cc. For details, please read Documentation/process/submitting-patches.rst. *HOWEVER*: the most serious problem is in this patch submission is... > @@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = { > }; > > static const struct dmi_system_id yc_acp_quirk_table[] = { > + { > + .driver_data = &acp6x_card, > + .matches = { > + DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Dell G15 5525"), > + } > + }, ... somehow the patch itself became broken (while v2 patch looked OK). Please verify how this got broken and try to submit correctly at the next time. thanks, Takashi