mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: "Maíra Canal" <mcanal@igalia.com>,
	linux-kernel@vger.kernel.org,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Marius Vlad" <marius.vlad@collabora.com>,
	"David Airlie" <airlied@gmail.com>,
	"Haneen Mohammed" <hamohammed.sa@gmail.com>,
	"Melissa Wen" <melissa.srw@gmail.com>,
	"Rodrigo Siqueira" <rodrigosiqueiramelo@gmail.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/vkms: Drop vkms_connector_destroy() wrapper
Date: Thu, 06 Apr 2023 13:47:16 +0200	[thread overview]
Message-ID: <878rf58c6z.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <accdc804-19e7-df59-7dd3-69c83f52405d@igalia.com>

Maíra Canal <mcanal@igalia.com> writes:

Hello Maíra,

> On 4/6/23 08:11, Daniel Vetter wrote:
>> On Thu, Apr 06, 2023 at 01:02:34PM +0200, Javier Martinez Canillas wrote:
>>> This helper is just a wrapper that calls drm_connector_cleanup(), there's
>>> no need to have another level of indirection.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>> 
>> On both patches:
>> 
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>> 
>> Aside, would be a nice cleanup to move vkms output stuff (crtc and
>> connector) over to the drmm_ stuff. The plane already does that.
>
> I sent a patch [1] a while ago moving the CRTC to the drmm_ functions.
> If you could take a look at it, it would be great.
>
> [1] https://lore.kernel.org/dri-devel/20230116205800.1266227-1-mcanal@igalia.com/T/
>

I've now reviewed both patches from your series and they look good to me.

> Best Regards,
> - Maíra Canal
>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


  reply	other threads:[~2023-04-06 11:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-06 11:02 [PATCH 0/2] drm/vkms: A couple of trivial cleanups Javier Martinez Canillas
2023-04-06 11:02 ` [PATCH 1/2] drm/vkms: Drop vkms_connector_destroy() wrapper Javier Martinez Canillas
2023-04-06 11:11   ` Daniel Vetter
2023-04-06 11:26     ` Maíra Canal
2023-04-06 11:47       ` Javier Martinez Canillas [this message]
2023-04-06 11:02 ` [PATCH 2/2] drm/vkms: Remove <drm/drm_simple_kms_helper.h> include Javier Martinez Canillas
2023-04-06 11:15 ` [PATCH 0/2] drm/vkms: A couple of trivial cleanups Thomas Zimmermann
2023-04-06 11:31 ` Maíra Canal
2023-04-07 11:22 ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rf58c6z.fsf@minerva.mail-host-address-is-not-set \
    --to=javierm@redhat.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marius.vlad@collabora.com \
    --cc=mcanal@igalia.com \
    --cc=melissa.srw@gmail.com \
    --cc=rodrigosiqueiramelo@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®