From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F8BDC761A6 for ; Thu, 30 Mar 2023 16:02:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230139AbjC3QCA (ORCPT ); Thu, 30 Mar 2023 12:02:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230225AbjC3QB6 (ORCPT ); Thu, 30 Mar 2023 12:01:58 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 167CB7EC3; Thu, 30 Mar 2023 09:01:57 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B7E751FE12; Thu, 30 Mar 2023 16:01:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1680192115; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HMiVIJW7f8S+buhdtTbu84jXewIpExbZfY0s1xagWoQ=; b=2C3lUp1AXCO17ZcJ5VuyBB2i28gJymGs2Xa4KbOX4HklqQ1wzH7ctS0kOQP2CXm53DtyFl Y53kpRy9Gh6SLmk3MwiR9s8TmDPvMcuqUVl7S/T0qvRxFl7tNxgVqx5eQVkUhTRy7sEcgX /82RGFjATGQGiKF8gagLz1QD9bztgJE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1680192115; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HMiVIJW7f8S+buhdtTbu84jXewIpExbZfY0s1xagWoQ=; b=RToNAL86t/p9McMUf/jMopqPC3J5NcMaRaVnci1D7WewRovpnWwII7kR+GWMIFM+6zi6mQ AQg686sYbBzJkjDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7D5241348E; Thu, 30 Mar 2023 16:01:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 20mwHXOyJWSfXQAAMHmgww (envelope-from ); Thu, 30 Mar 2023 16:01:55 +0000 Date: Thu, 30 Mar 2023 18:01:54 +0200 Message-ID: <878rfekz2l.wl-tiwai@suse.de> From: Takashi Iwai To: Dan Carpenter Cc: Mirsad Todorovac , Luis Chamberlain , linux-kselftest@vger.kernel.org, LKML , Greg Kroah-Hartman , Russ Weight , Takashi Iwai , Tianfei zhang , Shuah Khan , Colin Ian King , Randy Dunlap Subject: Re: [BUG] [PATCH RFC v2] selftests/firmware: copious kernel memory leaks in test_fw_run_batch_request() In-Reply-To: <5b103196-68d0-4d42-aa66-779af4d78532@kili.mountain> References: <97e284be-5018-9d18-feb2-7ec4b08c06fd@alu.unizg.hr> <26fd581a-1b9f-4960-8457-61d725511cee@kili.mountain> <5b103196-68d0-4d42-aa66-779af4d78532@kili.mountain> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Mar 2023 17:44:42 +0200, Dan Carpenter wrote: > > I admire your enthusiam. :) What about if we just did this? Does it > help with the leaks? > > regards, > dan carpenter > > diff --git a/lib/test_firmware.c b/lib/test_firmware.c > index 05ed84c2fc4c..626b836895f4 100644 > --- a/lib/test_firmware.c > +++ b/lib/test_firmware.c > @@ -895,6 +895,9 @@ static ssize_t trigger_batched_requests_store(struct device *dev, > > mutex_lock(&test_fw_mutex); > > + if (test_fw_config->reqs) > + return -EBUSY; > + This leaves the mutex locked. It should be the following instead, I suppose? if (test_fw_config->reqs) { rc = -EBUSY; goto out_unlock; } Takashi