mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Chin En Lin <shiyn.lin@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	Chin En Lin <shiyn.lin@gmail.com>
Subject: Re: [PATCH v2] Documentation: x86: Fix obsolete name of page fault handler
Date: Tue, 05 Apr 2022 10:30:16 -0600	[thread overview]
Message-ID: <878rsjebmv.fsf@meer.lwn.net> (raw)
In-Reply-To: <20220318142536.116761-1-shiyn.lin@gmail.com>

Chin En Lin <shiyn.lin@gmail.com> writes:

> Since commit 91eeafea1e4b ("x86/entry: Switch page fault exception to
> IDTENTRY_RAW"), the function name of the page fault handler is out of date.
> And because of commit aa37c51b9421 ("x86/mm: Break out user address space
> handling"), the description of search_exception_table is not correct
> anymore. It may mislead the user who wants to use the documentation to
> figure out the page fault handler.
>
> Also, fix typo and add the parentheses after function and macro name.

"Also" in a changelog like this is an indication that you've moved on to
an independent change that should be done as its own patch.  That is
certainly true of typo fixes and such, which should be separated out
from more substantive changes.

> Signed-off-by: Chin En Lin <shiyn.lin@gmail.com>
> ---
>  Documentation/x86/exception-tables.rst | 23 +++++++++++++----------
>  1 file changed, 13 insertions(+), 10 deletions(-)

Nonetheless, the patch seems clear enough and nobody has objected, so
I've applied it.

Thanks,

jon

      reply	other threads:[~2022-04-05 23:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18 14:25 Chin En Lin
2022-04-05 16:30 ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rsjebmv.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=shiyn.lin@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®