From: Phillip Susi <phill@thesusis.net>
To: gregkh@linuxfoundation.org, rafael@kernel.org, jeyu@kernel.org,
linux-kernel@vger.kernel.org
Cc: msekleta@redhat.com, Peter Rajnoha <prajnoha@redhat.com>
Subject: Re: [PATCH 1/2] kobject: return error code if writing /sys/.../uevent fails
Date: Thu, 29 Apr 2021 09:40:08 -0400 [thread overview]
Message-ID: <878s515hbp.fsf@vps.thesusis.net> (raw)
In-Reply-To: <20181205112745.12276-2-prajnoha@redhat.com>
Just an FYI, I've been tracking down a bug that was causing the debian
bullseye installer to immediately crash and reboot the xen domU and
bisected it to this commit. It appears that the Xen Virtual Keyboard
driver ( and at least one other, probably more ) were always broken and
failed to trigger the udev event, but this was never noticed. When this
patch returned the error code, it caused the d-i init scripts triggering
coldplug events to fail, which caused init to bail out, causing a kernel
panic.
In the future, when fixing error returns like this, could you please add
a big fat printk so that hopefully things that always should have failed
but didn't and now do can get noticed and fixed more quickly.
https://bugzilla.kernel.org/show_bug.cgi?id=207695
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983357
next prev parent reply other threads:[~2021-04-29 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 11:27 [PATCH 0/2] Fix return code and improve feature check for synthetic uevents Peter Rajnoha
2018-12-05 11:27 ` [PATCH 1/2] kobject: return error code if writing /sys/.../uevent fails Peter Rajnoha
2021-04-29 13:40 ` Phillip Susi [this message]
2021-04-29 17:27 ` Greg KH
2018-12-05 11:27 ` [PATCH 2/2] kobject: add kernel/uevent_features sysfs file Peter Rajnoha
2018-12-06 15:07 ` Greg KH
2018-12-05 16:30 ` [PATCH 0/2] Fix return code and improve feature check for synthetic uevents Greg KH
2018-12-06 8:40 ` Peter Rajnoha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s515hbp.fsf@vps.thesusis.net \
--to=phill@thesusis.net \
--cc=gregkh@linuxfoundation.org \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msekleta@redhat.com \
--cc=prajnoha@redhat.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome