From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E76AC04EB8 for ; Mon, 10 Dec 2018 05:38:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B1E420821 for ; Mon, 10 Dec 2018 05:38:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B1E420821 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726474AbeLJFin (ORCPT ); Mon, 10 Dec 2018 00:38:43 -0500 Received: from ozlabs.org ([203.11.71.1]:44747 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726292AbeLJFin (ORCPT ); Mon, 10 Dec 2018 00:38:43 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 43CsLn2B9jz9s4s; Mon, 10 Dec 2018 16:38:41 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Rob Herring , Greg Kroah-Hartman Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Frederic Barrat , Arnd Bergmann , linuxppc-dev@lists.ozlabs.org, Andrew Donnellan Subject: Re: [PATCH v2] misc: cxl: Use device_type helpers to access the node type In-Reply-To: <20181205191655.14612-1-robh@kernel.org> References: <20181205191655.14612-1-robh@kernel.org> Date: Mon, 10 Dec 2018 16:38:35 +1100 Message-ID: <878t0yeyas.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rob Herring writes: > Remove directly accessing device_type property and use the > of_node_is_type accessor instead. While not using it here, this is > part of eventually removing the struct device_node.type pointer. > > Cc: Frederic Barrat > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Cc: linuxppc-dev@lists.ozlabs.org > Acked-by: Andrew Donnellan > Signed-off-by: Rob Herring > --- > v2: > - Reword commit message as this change was using the .type ptr. I already have v1 in my next. cheers > diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c > index b66d832d3233..c79ba1c699ad 100644 > --- a/drivers/misc/cxl/pci.c > +++ b/drivers/misc/cxl/pci.c > @@ -1718,7 +1718,6 @@ int cxl_slot_is_switched(struct pci_dev *dev) > { > struct device_node *np; > int depth = 0; > - const __be32 *prop; > > if (!(np = pci_device_to_OF_node(dev))) { > pr_err("cxl: np = NULL\n"); > @@ -1727,8 +1726,7 @@ int cxl_slot_is_switched(struct pci_dev *dev) > of_node_get(np); > while (np) { > np = of_get_next_parent(np); > - prop = of_get_property(np, "device_type", NULL); > - if (!prop || strcmp((char *)prop, "pciex")) > + if (!of_node_is_type(np, "pciex")) > break; > depth++; > } > -- > 2.19.1