From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0300CC43382 for ; Fri, 28 Sep 2018 12:44:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73ED5216FE for ; Fri, 28 Sep 2018 12:44:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73ED5216FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728889AbeI1THq convert rfc822-to-8bit (ORCPT ); Fri, 28 Sep 2018 15:07:46 -0400 Received: from ozlabs.org ([203.11.71.1]:58457 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728765AbeI1THq (ORCPT ); Fri, 28 Sep 2018 15:07:46 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 42MBFM4brmz9s1x; Fri, 28 Sep 2018 22:44:07 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Christophe LEROY , Benjamin Herrenschmidt , Paul Mackerras Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc: wire up memtest In-Reply-To: <9f0055e2-ebd1-649b-272e-cb9b58bd4e15@c-s.fr> References: <871s9euw4m.fsf@concordia.ellerman.id.au> <9f0055e2-ebd1-649b-272e-cb9b58bd4e15@c-s.fr> Date: Fri, 28 Sep 2018 22:44:07 +1000 Message-ID: <878t3lu6zs.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christophe LEROY writes: > Le 28/09/2018 à 05:41, Michael Ellerman a écrit : >> Christophe Leroy writes: >>> Add call to early_memtest() so that kernel compiled with >>> CONFIG_MEMTEST really perform memtest at startup when requested >>> via 'memtest' boot parameter. >>> >>> Signed-off-by: Christophe Leroy >>> --- >>> arch/powerpc/kernel/setup-common.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c >>> index 93fa0c99681e..904b728eb20d 100644 >>> --- a/arch/powerpc/kernel/setup-common.c >>> +++ b/arch/powerpc/kernel/setup-common.c >>> @@ -33,6 +33,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >>> #include >>> @@ -917,6 +918,8 @@ void __init setup_arch(char **cmdline_p) >>> /* Parse memory topology */ >>> mem_topology_setup(); >>> >>> + early_memtest(min_low_pfn << PAGE_SHIFT, max_low_pfn << PAGE_SHIFT); >> >> On a ppc64le VM this boils down to early_memtest(0, 0) for me. >> >> I think it's too early, we don't set up max_low_pfn until >> initmem_init(). >> >> If I move it after initmem_init() then it does something more useful: > > Ok. On my 8xx max_low_pfn is set in mem_topology_setup(). > > Moving the test afte initmem_init() still works on the 8xx so I'll do that. Great, thanks. cheers