mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: Bassem Boubaker <bassem.boubaker@actia.fr>
Cc: linux-kernel@vger.kernel.org, Oliver Neukum <oliver@neukum.org>,
	linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN
Date: Tue, 27 Feb 2018 13:29:15 +0100	[thread overview]
Message-ID: <878tbebopw.fsf@miraculix.mork.no> (raw)
In-Reply-To: <1519732192-29332-1-git-send-email-bassem.boubaker@actia.fr> (Bassem Boubaker's message of "Tue, 27 Feb 2018 12:49:52 +0100")

Bassem Boubaker <bassem.boubaker@actia.fr> writes:

> +#define GEMALTO_VENDOR_ID	0x1e2d

This is defined as CINTERION_VENDOR_ID in drivers/usb/serial/option.c.

I have no idea which defintion is most correct, but I believe the macros
should be kept identical whatever you decide. Anything else is just
unnecessarily confusing.

IMHO the company name tracking macros have grown beyond useful a long
time ago. They just make it harder to grep for the IDs without adding
any useful information whatsoever. And because you have cases like this
where the same number end up having different names, they sometimes hide
information which a plain number would have revealed.



Bjørn

  reply	other threads:[~2018-02-27 12:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-27 11:49 Bassem Boubaker
2018-02-27 12:29 ` Bjørn Mork [this message]
2018-02-27 12:43   ` Oliver Neukum
2018-02-27 13:04 ` Bassem Boubaker
2018-02-27 13:11   ` Oliver Neukum
2018-02-27 19:44   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tbebopw.fsf@miraculix.mork.no \
    --to=bjorn@mork.no \
    --cc=bassem.boubaker@actia.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@neukum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®