mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org,
	kernel-hardening@lists.openwall.com,
	Anna Schumaker <anna.schumaker@netapp.com>,
	David Howells <dhowells@redhat.com>,
	David Safford <safford@us.ibm.com>,
	"David S. Miller" <davem@davemloft.net>,
	Gilad Ben-Yossef <gilad@benyossef.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Gustavo Padovan <gustavo@padovan.org>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Jeff Layton <jlayton@poochiereds.net>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	Marcel Holtmann <marcel@holtmann.org>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	keyrings@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	linux-nfs@vger.kernel.org, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH 0/6] Constant Time Memory Comparisons Are Important
Date: Sun, 11 Jun 2017 11:13:01 +0300	[thread overview]
Message-ID: <878tkzq6wi.fsf@purkki.adurom.net> (raw)
In-Reply-To: <20170610025912.6499-1-Jason@zx2c4.com> (Jason A. Donenfeld's message of "Sat, 10 Jun 2017 04:59:06 +0200")

"Jason A. Donenfeld" <Jason@zx2c4.com> writes:

> Whenever you're comparing two MACs, it's important to do this using
> crypto_memneq instead of memcmp. With memcmp, you leak timing information,
> which could then be used to iteratively forge a MAC.

Do you have any pointers where I could learn more about this?

-- 
Kalle Valo

  parent reply	other threads:[~2017-06-11  8:13 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-10  2:59 Jason A. Donenfeld
2017-06-10  2:59 ` [PATCH 1/6] sunrpc: use constant time memory comparison for mac Jason A. Donenfeld
2017-06-10  2:59 ` [PATCH 2/6] net/ipv6: " Jason A. Donenfeld
2017-06-10  2:59 ` [PATCH 3/6] ccree: use constant time memory comparison for macs and tags Jason A. Donenfeld
2017-06-10  7:43   ` Gilad Ben-Yossef
2017-06-10 10:54     ` Jason A. Donenfeld
2017-06-10 21:43       ` Henrique de Moraes Holschuh
2017-06-10  2:59 ` [PATCH 4/6] security/keys: use constant time memory comparison for macs Jason A. Donenfeld
2017-06-14  8:47   ` [kernel-hardening] " James Morris
2017-06-10  2:59 ` [PATCH 5/6] bluetooth/smp: use constant time memory comparison for secret values Jason A. Donenfeld
2017-06-10 13:49   ` Marcel Holtmann
2017-06-10  2:59 ` [PATCH 6/6] mac80211/wpa: use constant time memory comparison for MACs Jason A. Donenfeld
2017-06-13  8:20   ` Johannes Berg
2017-06-13 13:28     ` Jason A. Donenfeld
2017-06-11  8:13 ` Kalle Valo [this message]
2017-06-11 13:36   ` [PATCH 0/6] Constant Time Memory Comparisons Are Important Kees Cook
2017-06-11 20:48     ` Emmanuel Grumbach
2017-06-11 21:30       ` Emil Lenngren
2017-06-12  5:03         ` Emmanuel Grumbach
2017-06-12  7:33         ` Arend van Spriel
2017-06-11 21:06 ` Stephan Müller
2017-06-11 21:21   ` Jason A. Donenfeld
2017-06-11 21:20 ` [PATCH] rsa-pkcs1pad: use constant time memory comparison for MACs Jason A. Donenfeld
2017-06-20  3:38   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tkzq6wi.fsf@purkki.adurom.net \
    --to=kvalo@codeaurora.org \
    --cc=Jason@zx2c4.com \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=gilad@benyossef.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gustavo@padovan.org \
    --cc=jlayton@poochiereds.net \
    --cc=johan.hedberg@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    --cc=safford@us.ibm.com \
    --cc=trond.myklebust@primarydata.com \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®