From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751561AbdEOWIg (ORCPT ); Mon, 15 May 2017 18:08:36 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:38003 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751526AbdEOWIf (ORCPT ); Mon, 15 May 2017 18:08:35 -0400 X-Hashcash: 1:20:170515:linux-watchdog@vger.kernel.org::P4skqE+jjnrewLOL:00000000000000000000000000000002iAu X-Hashcash: 1:20:170515:linux-kernel@vger.kernel.org::bnq63CoENxUsrF/T:0000000000000000000000000000000005E+7 X-Hashcash: 1:20:170515:sebastian.reichel@collabora.co.uk::Lhw3HoK82/1w/gXS:00000000000000000000000000000Cdo X-Hashcash: 1:20:170515:linux@roeck-us.net::QVj818WGBKcrH7Pt:000000000000000000000000000000000000000000009xp X-Hashcash: 1:20:170515:wim@iguana.be::8itSfq4ko5DSGT7U:00002nQg From: Rasmus Villemoes To: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sebastian Reichel , Guenter Roeck , Wim Van Sebroeck Subject: Re: [PATCHv2] watchdog: core: add option to avoid early handling of watchdog Organization: D03 References: <20170512120532.12986-1-sebastian.reichel@collabora.co.uk> <4a4c4de8-31e4-8e15-8c63-ebd4165a63bf@roeck-us.net> Date: Tue, 16 May 2017 00:08:32 +0200 In-Reply-To: <4a4c4de8-31e4-8e15-8c63-ebd4165a63bf@roeck-us.net> (Guenter Roeck's message of "Sun, 14 May 2017 07:47:13 -0700") Message-ID: <878tlxpycf.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 14 2017, Guenter Roeck wrote: > On 05/12/2017 05:05 AM, Sebastian Reichel wrote: >> On some systems its desirable to have watchdog reboot the system >> when it does not come up fast enough. This adds a kernel parameter >> to disable the auto-update of watchdog before userspace takes over >> and a kernel option to set the default. The info messages were >> added to shorten error searching on misconfigured systems. >> >> Signed-off-by: Sebastian Reichel > > Minor nitpicks below (which I fixed up in my watchdog-next branch). > Otherwise Guenter, Sebastian, can I pursuade you to take a (second) look at the patches [1] I sent 4 months ago that implement the same thing, except that they also give a .config and a boot-cmdline way to define what "fast enough" means - which is necessary in many cases where it's simply not realistic to have userspace up-and-running before the dog is hungry. [1] https://lkml.org/lkml/2017/1/9/408 I'm of course happy to rebase and retest those on top of current master, but the implementation and semantics should be reviewable as-is. Rasmus