From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753348AbcE3AeL (ORCPT ); Sun, 29 May 2016 20:34:11 -0400 Received: from relmlor3.renesas.com ([210.160.252.173]:12367 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753114AbcE3AeI (ORCPT ); Sun, 29 May 2016 20:34:08 -0400 X-IronPort-AV: E=Sophos;i="5.22,559,1449500400"; d="scan'";a="212317765" Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=renesas.com; Message-ID: <878tysbdar.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Vinod Koul CC: Laurent Pinchart , Geert Uytterhoeven , Laurent Pinchart , sakato , OSD2 ML , , Subject: Re: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put() In-Reply-To: <20160526153414.GV2735@localhost> References: <87r3dywh6u.wl%kuninori.morimoto.gx@renesas.com> <20160514075731.GA23734@localhost> <2831766.dEtRrr4FvR@avalon> <20160526153414.GV2735@localhost> User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Date: Mon, 30 May 2016 00:34:01 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: TYXPR0101CA0023.jpnprd01.prod.outlook.com (10.168.40.161) To SG2PR06MB1709.apcprd06.prod.outlook.com (10.167.82.139) X-MS-Office365-Filtering-Correlation-Id: ec52a00d-2bd8-4b3a-a8c3-08d388221920 X-Microsoft-Exchange-Diagnostics: 1;SG2PR06MB1709;2:tbCxEFLR0NfnA/0FRjOmDtukL1unsuo5PllsJhSqcTmoh4Zm//iOKMTmNwxqSpOnhKDKsobcevJ/oIDzN2M7UdIClSk4viAOM3umrPtQpKq+1Df0be0c89EmQEEPQ9IaHKSEZbGh0srrfYdU8Maqs+YsWBTH0F7himdW9suJsnvtgqnEjAKr79I7rf5LroKR;3:q2D0l+POIOixaeXmHssEnd02z8HIffGMyju3woOST/BXKcwZz77fhngq4P43/RrJ/KO2/zodfOORgEJfR5EZWV3LWpo2A3kKIlHjre1wQhZgFkJWua6xzV3JR8dIdt5J X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB1709; X-Microsoft-Exchange-Diagnostics: 1;SG2PR06MB1709;25:2QM9mHZRlo42v9xpvW+1UGfN62vLQtR5/X6rQGDA/0khH2LBlNKzQGsxIWnxFztXwO59FO8bBhCaD1IPj07f2xAI3SIZefPqmb5jHGmxUO7L28dnElWRNdGfpfnWwUe8D290uFWvc+TSXq7Bk2MJ79T2EytiL6u7zrU4JjzvHpgcjziGbkoJRExXfcpDL/u33DegZ+xHlOgE+dngNqk42I/wbCXWGU1XSSfrVQQkIUDEvEz/fd8bB0orojxlHbzdpfFm2YeAGv4UqpCVQHdDZBbGZvAjt6rNpR3bgdkxDMTY962jXAhCCrofGdR3rHHObo+zGbwim7YFOqhRqVnc+GioP5vWr3VR6rV5JwCU9WLdCB8AvjjRrYE8/HeT1E5t2f4zF02bEz6ULpBSvH7kP9Kd2Vy1Wra5v3O++xythZxr1f817gLh33tNcSiykW9c8XCFOmCVYqvE6uVC/Vm78dKf5zsONEQAb2E+aFzn/kdtFbF8myGd7t4E4ujuswnJLYvMyVcwx0f5FQzx0DN/7fUSojprEF81UazpyRXhWvqXXej7cBk08xTYmpBxLpe/XurFLwPAjr1hP7PWQIABiIfoHe/2ezRo0/81t/DNq+m/E/KfrZ8nlNKTPHR11hFiHVXSDfhvpn+YWaqayp9dMC7/JYIjODHiLJo5GqFRcwhwu7Oczz1AZHcAqXr75J3iG4mDshIyhatOzoBzWTZJBJ0QrcvLhq8fvDLb9NsBzVpFPSAwSe/xgV8wzpyd27j3ERSuwBUf8Q8dlEL5DvbaU9mTiF4LpjgVqxp3T1MtvP4= X-Microsoft-Exchange-Diagnostics: 1;SG2PR06MB1709;20:EJL5eo8MKuRcZAy0ufZ0LHmA7Ubs/s6OYArVE0GzVwIr44js9i2gxWyz7kVeJdYDpweH2+ioPRZpy9tOZxlYbVZcH7yeaHz44mZPla+al2u5Dc4++nI1Qfl2PVvloxnrQ5FbCZbdLDTmTHFAY1uU+V4yHPIYvJRbd1zzHPh/i5ILpXcP+x+QSS+WU+SIXF5IbLgHIgAxloz0y4ltNFMkIe6PQzNV95wEH3+A1Gep5D0TJDKYNj1T9hWF2rF/E+NUUMN3x3wAFif7JVczQC/HxSKTJE1KljJ/Bv0D6gyr4/1M8NGHWPEncJQnqN+sDs/DprLStCdBviYL6JmIuLYvpFHdse7DBMuUnEBsMmj4ld0OR8Fe5VctHhkC6373Rj/ANaB9X4xAI1LxTrBie4KTBaEB9mNWukplwSTGXGD225OORirg0FabgSMRT7qwasluNvDBWBrqL+ziFQN8pgoRxxolGjOIUoaZSWa0i28Nmfu4fxgSeK3GJ4o2nulPQGYv;4:L5D3eK8vNWMO0eFhJ5GW73HD841HSWcyKkfV6UUcZVlvvT5NvzTPvOjX75fRcMuNx+0sPxMlYhwxMpePnICCT5lkh1+0l8FEhPgsJUTvE7MLJVlYmOSnFbP1P+uS8PR3Kso+vcFLvAus1OFMGKVotfJubB1AeY3R4eiX6Chj+oiraMG9GwPn162LoKe4y7uw2ERACsDyxE/GF09eTOiKTzsAoGj0OpaH9wQEgBaZJfPFE/c3D+E+0LfvfiL99kjrKXfWV059qcGg6JIBF+EdUJw2f/WHb/gi8CPlhSk9XChnqQlaUDWO7RECnYRV3GF5gemKn/hEXI9h12XrMPJneCgT8cp8oZSk2b5CHSZhT8BGc0ztWuOiAdnAr9Bf94So X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:SG2PR06MB1709;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB1709; X-Forefront-PRVS: 09583628E0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(979002)(6009001)(54534003)(19300405004)(5008740100001)(50466002)(92566002)(33646002)(46406003)(4326007)(36756003)(8676002)(93886004)(50986999)(81166006)(86362001)(6116002)(3846002)(586003)(2950100001)(19580395003)(15975445007)(5004730100002)(69596002)(53416004)(54356999)(76176999)(23726003)(77096005)(4001350100001)(42186005)(110136002)(2906002)(189998001)(47776003)(83506001)(66066001)(2690400003)(16060500001)(562404015)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:SG2PR06MB1709;H:morimoto-PC.renesas.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SG2PR06MB1709;23:QR3+pQ4Fe191n8iIfVqG15mKDqsITC7wSycVJViAt?= =?us-ascii?Q?FE3L6JC+UZJm9ANzoUe18vxaLj+AJHJf5vBVHQadTIFZg2a6JVrspmQsMcZm?= =?us-ascii?Q?FcWo+jqBnQ6+hpduEcqE5aZqCdJd884Vr7X/8QXRNcneZRxqL2X+uzurLk1x?= =?us-ascii?Q?AXcoD7KSI+yY/KAcK/iOPqu0OzXaSy3a1o8FrzHUnIKtG0TuDm7mm2DvLxp8?= =?us-ascii?Q?/U+SuJMTwTP+Ez+ZMLpj5nkQIQh2GX3++PDCZipMGV4w5uNMTul280/v00ce?= =?us-ascii?Q?feeNh0xcmsG/rZlz52qTOKct3XAbb2z/EEyNkK8Ht5gDQHlKI+FRQv/haAQE?= =?us-ascii?Q?RwtEqhanaM4AiN6rG6c06Ti3ZrScRf2GFLbsqtTN7NzmUv58djS2q+sNyn0f?= =?us-ascii?Q?eKSrdapeAGLd0Hr1n28ybbdQMWXUX6H4bmGVk8VTQungyx/qv/yOONbcEm0L?= =?us-ascii?Q?rch30GVe23wMM3yOe2QnZwcbYSvydxI6PHuj8a4uucFX9eibX/IwW3QVJRhE?= =?us-ascii?Q?3h/SFrDhDxklibCMGj3q47Awfn1/danros88be7/19xNIkXSSeujP+L0CuD3?= =?us-ascii?Q?bc/yK9lZYb46z1cwhk5oHBWvbOE7VUr3KVWMJO7ebOsDHi1jLijbEI53cf8a?= =?us-ascii?Q?mPQbsdMr1tNCAyA0St+c+vv4lLcKnpvbxlhgV9rPtlrHzDPDZ3cx0KH+3aMo?= =?us-ascii?Q?rTfJ3XvGQi+xBzWNrz0I3UBIP0t2r6RS20USZlW0dcxCS8SAo5Qr3cznY/ld?= =?us-ascii?Q?F8E55uWp4mzOX1Alpe56tlIoAWBDRD03ZHuUJE9PyFJsFCGaEHaZPOawz9VZ?= =?us-ascii?Q?yVLwl8eAdkIoxFRQRh0NWCPTRhyS3TyZipQ2I/Wd5KQ5tcICoSmn/+vEDnJT?= =?us-ascii?Q?QsJK2ZXyqc5LOcU8wyWiZ54zNySsHeiFi53igKQXcTTIevKO7VIDaE7YtMtJ?= =?us-ascii?Q?9pL6oSCX52iEWICXGRF/MUQ+GKK4Wlf5VixL0QW05Gxtnqwj/0j0R0fuSL26?= =?us-ascii?Q?JKBVjd56NdJ3uCmxe7HQljyXzby++euEb5wIQ/3/RVw4xSVirxV9KUzLIoFr?= =?us-ascii?Q?DXQvdbQa2/Ysgg2i7JQAeL66PYzu+tMvdPt2ZrDLL0YFYGoP4huTyy6XYZCV?= =?us-ascii?Q?SbVjbEM34oQOFATTOq2zjCaSYrXr2xL1MWuoBfcj/zdNtZlvTBMC/IqU8+Ea?= =?us-ascii?Q?u3yyB3JaaRGJ4M=3D?= X-Microsoft-Exchange-Diagnostics: 1;SG2PR06MB1709;5:cclFv6fdURcR6dhLFnh9gr3XB7tztfBElPXG3TbNa5qdOvAc+9+lWMZysWJ01bYM5IoFpV9dID1gGyTA2LEvIxWQvGBDwnVSQfQL1vSMz0FwIsocKr4gLBl8TCnAw/fZa//npC6v47VRawY+iUJZ2Q==;24:RWWmHy3bO0/L5nhrlF18APshtHk6pP8BwfO3k39FSSYT/MZdB/lLNJtdvoX9t1mlQTS0bv75a5AvrIuPSoTqwEnrOlmqLJ/2LEJouZhSvsc=;7:aKas33XEf/Exr7+XmQEnadxkmU3acY5coPfIB+A9s4P7+LMya6ElFy+kdTfXq5YOxBZIYI+o1ux4YksI9chRlPWvUr4HCUGnsVVE/UsOp9IYHzanxxU30Xr4502hACA8h9//d1l09Bhl40gGE7aTEOJhlPtyFH/M4qOKMR8J9rZGzIZA2agkxrqDSggKSgbM;20:CFPsFedOdI7VDEiTg6ZhLjo++uHvEsmk+THFkAOiLbrVUMVjAK/EYL52iRkHZB1M+CVcDozOF/C94EzjduGRiSbBZ+t7xMC7IbeuSSv2jPZ4jjjkTUkj5OAWcUOZdH70x6hSHGLCGs8qt6Va+1Rfy9aHwrOkkOEKbnFz7iBEU6c= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2016 00:34:01.1051 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB1709 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vinod > > > > Current rcar_dmac_desc_put() is using list_add_tail() in order to > > > > push used descriptor to list of free descriptors, and next DMA transfer > > > > try to reuse it from this list. But because it is using *_tail(), > > > > this reuse effect can't be obtained without using all of them. > > > > For a longer-term solution, we should allocate hardware descriptors > > > > using GFP_KERNEL instead of GFP_NOWAIT, but it is difficult today. > > > > This patch uses list_add() instead of list_add_tail() for short-term > > > > solution. > > > > > > Applied, thanks > > > > Thanks, but where did you apply it to ? I can't find it in your tree. > > I changed my mind after this and felt that we should document above > in the changelog as well and replied to Kuninori few moments after this [1] > > Sorry if that wasn't clear that am not applying this. > > Please resend it with update changelog > > [1]: http://www.spinics.net/lists/dmaengine/msg09585.html OK, will do Best regards --- Kuninori Morimoto