From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754124AbcEBP3v (ORCPT ); Mon, 2 May 2016 11:29:51 -0400 Received: from anholt.net ([50.246.234.109]:42439 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754057AbcEBP3j (ORCPT ); Mon, 2 May 2016 11:29:39 -0400 From: Eric Anholt To: Martin Sperl Cc: Michael Turquette , Stephen Boyd , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Warren , Lee Jones Subject: Re: [PATCH 2/2] clk: bcm2835: Skip PLLC clocks when deciding on a new clock parent In-Reply-To: References: <1461699585-6649-1-git-send-email-eric@anholt.net> <1461699585-6649-2-git-send-email-eric@anholt.net> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 02 May 2016 08:29:30 -0700 Message-ID: <878tzsiilh.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Martin Sperl writes: >> On 26.04.2016, at 21:39, Eric Anholt wrote: >>=20 >> If the firmware had set up a clock to source from PLLC, go along with >> it. But if we're looking for a new parent, we don't want to switch it >> to PLLC because the firmware will force PLLC (and thus the AXI bus >> clock) to different frequencies during over-temp/under-voltage, >> without notification to Linux. >>=20 >> On my system, this moves the Linux-enabled HDMI state machine and DSI1 >> escape clock over to plld_per from pllc_per. EMMC still ends up on >> pllc_per, because the firmware had set it up to use that. >>=20 >> Signed-off-by: Eric Anholt >> Fixes: 41691b8862e2 ("clk: bcm2835: Add support for programming the audi= o domain clocks") >> =E2=80=94 > > I guess this patch looks to me as if it is a policy inside the kernel, > which is AFAIK frowned upon. Can you come up with a use for putting peripherals on PLLC ever, such that we need choice? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXJ3JaAAoJELXWKTbR/J7o/d4QAIxRYFvmaYfcuagsLUQkm6Of v32RQR/pEK4qAByrgUkL36KY5iPyc35hKViTFtwic4uKoVZvmSBUw6MnzXRX3Txh Zdh4sRqx51PQiSoSo7Dmm043gP/OJajnQJ86QhLCTb8wY2MgaTbiH5kE+xhxlbG0 t3dC990fihylT/cU0JjbFWHBwcHZlxKYeLNLX1FWWCICn1Y9zoXmFfhceImYS9ut 4BZqlsmizIOFUHU8f9tIqOA0tUJlSIc9PSQS+B7GCVI3MtTdUeQ+gu9jygz225v6 kfetWfZb4/r7OJFDxWfIZGSy4r/vy6EI6uP/MV60Q4rM3xxiMCNI36oZN6eLPhRB SRl2vRZaNchGGZsjzvJ0uhk+39lOP2Jryg8+uc0I1iLnfKlNN0vnbWohZZV1b06A 3gcnPZmrOU+zW0f82nVgvRU8hSzWr7/ZfdvHhs2gq8D8vSgGqJnHofujeWHHA/ws 97XArVt85zbVd6wR7Nrm5E5DSzstzUCHdoW0D3W90SmsUSxIs4NnBSsc6aQPzrOD PKffcdQ0ebVwBm6vjdKNz+6TYtt8ntrgBq2QPZEBC91gtNb+MuAdSOSyn2mZeOa2 3XmxcaO8vUClFo5OXroQYJb7dlu3RVDTtmwgYCZg+Qahqq2FMG+Ef+wJpl3z8DSQ clhChQ1atk4KkYESPQY3 =ogsp -----END PGP SIGNATURE----- --=-=-=--