From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754479AbcDMTt0 (ORCPT ); Wed, 13 Apr 2016 15:49:26 -0400 Received: from anholt.net ([50.246.234.109]:46592 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbcDMTtY (ORCPT ); Wed, 13 Apr 2016 15:49:24 -0400 From: Eric Anholt To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org Cc: linux-rpi-kernel@lists.infradead.org, Jason Cooper , Stephen Warren , Marc Zyngier , Lee Jones , linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH 2/4] irqchip: bcm2836: Drop smp_set_ops on arm64 builds In-Reply-To: <201604082243.52300.arnd@arndb.de> References: <1459827858-3871-1-git-send-email-eric@anholt.net> <1459827858-3871-3-git-send-email-eric@anholt.net> <201604082243.52300.arnd@arndb.de> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 13 Apr 2016 12:49:19 -0700 Message-ID: <878u0hwaps.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Arnd Bergmann writes: > On Tuesday 05 April 2016, Eric Anholt wrote: >> For arm64, the bootloader will instead be implementing the spin-table >> enable method. >>=20 >> Signed-off-by: Eric Anholt >> --- >> drivers/irqchip/irq-bcm2836.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >>=20 >> diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836= .c >> index 233ccdd..4ae9f76 100644 >> --- a/drivers/irqchip/irq-bcm2836.c >> +++ b/drivers/irqchip/irq-bcm2836.c >> @@ -223,6 +223,7 @@ static struct notifier_block bcm2836_arm_irqchip_cpu= _notifier =3D { >> .priority =3D 100, >> }; >>=20=20 >> +#ifdef ARM >> int __init bcm2836_smp_boot_secondary(unsigned int cpu, >> struct task_struct *idle) >> { >> @@ -238,7 +239,7 @@ int __init bcm2836_smp_boot_secondary(unsigned int c= pu, >> static const struct smp_operations bcm2836_smp_ops __initconst =3D { >> .smp_boot_secondary =3D bcm2836_smp_boot_secondary, >> }; >> - >> +#endif >> #endif >>=20=20 >> static const struct irq_domain_ops bcm2836_arm_irqchip_intc_ops =3D { >> @@ -256,8 +257,11 @@ bcm2836_arm_irqchip_smp_init(void) >> register_cpu_notifier(&bcm2836_arm_irqchip_cpu_notifier); >>=20=20 >> set_smp_cross_call(bcm2836_arm_irqchip_send_ipi); >> + >> +#ifdef ARM >> smp_set_ops(&bcm2836_smp_ops); >> #endif >> +#endif >> } > > I'd suggest instead using CPU_METHOD_OF_DECLARE and moving the SMP code > to arch/arm/mach-bcm/platsmp-bcm2835.c. It doesn't really belong in the > irqchip code. I think because of DT ABI (sigh) we're stuck with the current implementation. FWIW, I had started with the SMP bits in a platsmp.c, but moved it into the irqchip because that was so much simpler than reaching over into the irqchip node to map its registers. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXDqK/AAoJELXWKTbR/J7oa2sQAKn3UKXgVd8u4S6XaKmQp7ed AoV3324M4qA42pyNKXwKr2EImERHV/X6ySrivgyd3bxFkjTDkrF3D+q3hjsjXbgG +yXl7P/NJhOPdLk9oFcaNS5h3odSWE0fiiMImwj28eAyvkwsLV3b528bVWyRb5qW 0ktqQsSa/gAvxCP7wNN5tLbat0bDGqYSBJkAYjRWahMwxabyTu6mo5zomujQgNxv 98MggycKvCLsJJg7eABsp/XPt5XUOP3flLMApVKSM+J1j/9m6CI3aDJpWYjsY2ew 8QQOTvYtoO93xY6f2FOiajwNFRxiOvsn+MOlbbp6oImoaSgCxU1mn6OhygczqxIo loFAAPe2kjouzrtNRFSJcD2SVr4ICNwgy1bCzMsDdPPCDBA70JsBDQuE95+6wsyH L6W22+yehc0VBWmTrWwjMriYLQscZ94AadQngEmv6R9N7EfpnQhKmmm485JXlF6g X4u4kMnMxccqbhHFEDf/y74Jo4d2aa4NSBYQvkgBTzr0sA9DBRcHVNhWNWlKhu7s SJw4cEfevIMpx3vjIjq37Ifx+fqcHmKvuKt5xbVYRqph5sDud1unFLzUdy68Dyxj aI5/hYAMy87nLcaHTyDh6nUaCRcchxI4iJfeS1ELLnuejM1zLq4G6eMRfeA3hyhv bokK8cn+1d5wL4NCinGp =AneI -----END PGP SIGNATURE----- --=-=-=--