From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752751AbbJLAfj (ORCPT ); Sun, 11 Oct 2015 20:35:39 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:34602 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752718AbbJLAfi (ORCPT ); Sun, 11 Oct 2015 20:35:38 -0400 From: Daniel Axtens To: Colin King , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/pseries/hvcserver: don't memset pi_buff if it is null In-Reply-To: <1444330858-5508-1-git-send-email-colin.king@canonical.com> References: <1444330858-5508-1-git-send-email-colin.king@canonical.com> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 12 Oct 2015 11:35:20 +1100 Message-ID: <878u7853g7.fsf@gamma.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Colin, This looks good. Out of curiousity, how did you find it? Code inspection? Bug? Static analysis? Not that it's particularly meaningful for such a trivial fix, but FWIW: Reviewed-by: Daniel Axtens Regards, Daniel Colin King writes: > From: Colin Ian King > > pi_buff is being memset before it is sanity checked. Move the > memset after the null pi_buff sanity check to avoid an oops. > > Signed-off-by: Colin Ian King > --- > arch/powerpc/platforms/pseries/hvcserver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/pseries/hvcserver.c b/arch/powerpc/pl= atforms/pseries/hvcserver.c > index eedb645..94a6e56 100644 > --- a/arch/powerpc/platforms/pseries/hvcserver.c > +++ b/arch/powerpc/platforms/pseries/hvcserver.c > @@ -142,11 +142,11 @@ int hvcs_get_partner_info(uint32_t unit_address, st= ruct list_head *head, > int more =3D 1; > int retval; >=20=20 > - memset(pi_buff, 0x00, PAGE_SIZE); > /* invalid parameters */ > if (!head || !pi_buff) > return -EINVAL; >=20=20 > + memset(pi_buff, 0x00, PAGE_SIZE); > last_p_partition_ID =3D last_p_unit_address =3D ~0UL; > INIT_LIST_HEAD(head); >=20=20 > --=20 > 2.5.0 > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJWGwBIAAoJEPC3R3P2I92Fq1kQANpeOBt2e596Y7gVyZLeQfBQ xEaFx70ZZh4SWJMU1ZRPKh4ur+GPPobYsQSCPpBCHq4xM+qCnQYN4Rly3BY/FL4/ K488PltYjzM1ixbzz7egtJB0zdNLeRXTt+Go2B0C4oqy6kwd8ePYyQBwqnJ/SmKt A6EhfESLvNnEN06LBzqiz8RzD7hTsYkfGzDEemwoVVT4zMdbzFkRNbOLerRGsUKW cPpRjKsxUtnSAaMDuO8mH0U77HpQK7qlNbN0m8Gnv87QmIbxcYr0b9egGZVsUEZP Sx5FuIuisH8mIl4V41f8kczvngHWJpzfeecgZiiAEG+fO+y6pYiRJEP0Dr/+AqSZ 3a0eJowZEyxZGibLYtja7y7yJV2cJGmAhO+jJRHNPojj+2tq2+H5IIEt+PF9X9nI bIM23FVwfxqPb+M/qd8HnBHiiJY680x8X0L7Vvmdhtf4CT/6vUrmPsNIhQqLdARF GcXkaQ4NWyi46sGZ/PXLe3F3WdSyLVRbfzbG0L/mUG70Rqa/wSQ/g0qTXdzpnP+G 1Csvr/J3HD+fDVxTi11wWOBsb8RP8AIHW+Jq4tNDDLafQQO1nNVYW6vZ6mKKkUrA tIh6GNDEjPp7nY3KBBI0OnpCKj3ZzJG6TDV6fCZQMSbmiLBljVA+DVD4ZWML4ykS Ac6OV93aU6aKt1l3lc1G =dQiX -----END PGP SIGNATURE----- --=-=-=--