From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Andrew Morton <akpm@linux-foundation.org>, Jens Axboe <axboe@kernel.dk>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [RFC PATCH v2] lib: scatterlist: add sg splitting function
Date: Tue, 04 Aug 2015 19:04:36 +0200 [thread overview]
Message-ID: <878u9rm1cr.fsf@belgarion.home> (raw)
In-Reply-To: <20150803161939.2edd494eb64bc81ea8e91c16@linux-foundation.org> (Andrew Morton's message of "Mon, 3 Aug 2015 16:19:39 -0700")
Andrew Morton <akpm@linux-foundation.org> writes:
>> include/linux/scatterlist.h | 5 ++
>> lib/scatterlist.c | 189 ++++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 194 insertions(+)
>
> It's quite a bit of code for a fairly specialised thing. How ugly
> would it be to put this in a new .c file and have subsystems select it
> in Kconfig?
I have no idea about the "ugliness", but why not ...
If nobody objects, and in order to submit a proper patch, there are decisions to
make :
- what will be the scope of this new .c file ?
- only sg_plit() ?
- all sg specialized functions, ie. sg_lib.c ?
- will include/linux/scatterlist.h have an "ifdefed" portion for what X.c
offers ?
- what naming for X.c and the config entry ?
What about adding this to lib/Makefile, and one ifdef to scatterlist.h ? :
obj-$(CONFIG_SG_LIB) += sg_lib.o
Cheers.
--
Robert
next prev parent reply other threads:[~2015-08-04 17:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-01 13:17 Robert Jarzmik
2015-08-03 23:19 ` Andrew Morton
2015-08-04 17:04 ` Robert Jarzmik [this message]
2015-08-04 21:24 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u9rm1cr.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®