mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Vince Weaver <vincent.weaver@maine.edu>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Stephane Eranian <eranian@gmail.com>
Subject: Re: perf: aux area related crash and warnings
Date: Thu, 18 Jun 2015 16:11:03 +0300	[thread overview]
Message-ID: <878ubh2mc8.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20150618103249.GK19282@twins.programming.kicks-ass.net>

Peter Zijlstra <peterz@infradead.org> writes:

> On Tue, Jun 16, 2015 at 02:37:06PM +0300, Alexander Shishkin wrote:
>> Ok, here's what I propose for this one.
>
> As discussed yesterday, I think we want to change to how we do reference
> counting for the regular buffers, but that will require quite a bit of
> work.
>
> For the interim we can avoid the issue by something like the below;
> compile tested only.

Looks good and works fine on my tests. Only I'd maybe add a small
comment on why reusing rcu_head.next doesn't set off call_rcu()
debugging. Other than that, fwiw,

Reviewed-and-tested-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>

Thanks,
--
Alex

  reply	other threads:[~2015-06-18 13:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12  3:15 Vince Weaver
2015-06-12 18:42 ` Vince Weaver
2015-06-15 12:20   ` Peter Zijlstra
2015-06-15 12:49     ` Alexander Shishkin
2015-06-15 20:24       ` Ingo Molnar
2015-06-16 11:37       ` Alexander Shishkin
2015-06-18  9:09         ` Ingo Molnar
2015-06-18  9:35           ` Alexander Shishkin
2015-06-18 10:24             ` Peter Zijlstra
2015-06-18 16:30           ` Paul E. McKenney
2015-06-18 10:32         ` Peter Zijlstra
2015-06-18 13:11           ` Alexander Shishkin [this message]
2015-06-19 14:21           ` Vince Weaver
2015-07-06 15:34           ` [tip:perf/urgent] perf: Fix AUX buffer refcounting tip-bot for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878ubh2mc8.fsf@ashishki-desk.ger.corp.intel.com \
    --to=alexander.shishkin@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=eranian@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome