From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Amit Sahrawat <amit.sahrawat83@gmail.com>
Subject: Re: [PATCH 2/2] fat : no need to reset EOF in ent_put for FAT32
Date: Sun, 26 Aug 2012 23:02:18 +0900 [thread overview]
Message-ID: <878vd1wy39.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <1345883011-6263-1-git-send-email-linkinjeon@gmail.com> (Namjae Jeon's message of "Sat, 25 Aug 2012 04:23:31 -0400")
Namjae Jeon <linkinjeon@gmail.com> writes:
> #define FAT_ENT_EOF(EOF_FAT32)
>
> there is no need to reset value of 'new' for FAT32 as the values is
> already correct
>
> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
> Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
> ---
> fs/fat/fatent.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c
> index 31f08ab..af53815 100644
> --- a/fs/fat/fatent.c
> +++ b/fs/fat/fatent.c
> @@ -186,8 +186,6 @@ static void fat16_ent_put(struct fat_entry *fatent, int new)
>
> static void fat32_ent_put(struct fat_entry *fatent, int new)
> {
> - if (new == FAT_ENT_EOF)
> - new = EOF_FAT32;
>
Please remove this new line too. If it was removed,
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> WARN_ON(new & 0xf0000000);
> new |= le32_to_cpu(*fatent->u.ent32_p) & ~0x0fffffff;
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2012-08-26 14:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-25 8:23 Namjae Jeon
2012-08-26 14:02 ` OGAWA Hirofumi [this message]
2012-08-27 1:26 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vd1wy39.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@linux-foundation.org \
--cc=amit.sahrawat83@gmail.com \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®