Re: [PATCH take 2][RFC] fat: Save FAT root directory timestamps to volume label

[OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>]

Jörg Schummer <ext-jorg.2.schummer@nokia.com> writes:

> Hello again,
>
> just in case you (or perhaps somebody else) have a minute to assist me..
>
> On Mon, 2009-07-27 at 13:47 +0200, ext OGAWA Hirofumi wrote:
>
>> BTW, the patch has several bugs. fat_get_label_entry() doesn't check
>> IS_FREE(), is it right?
>
> Not 100% sure if it's needed in a consistent fs, but I guess it
> shouldn't do any harm, so I added it.

If label was removed, what happen? I was assumed utility does

    label_de->name[0] = DELETED_FLAG;


>> spin_lock() usage is wrong.
>
>>From the code, I'm not totally sure then what inode_hash_lock is
> supposed to protect in fat_write_inode. Probably it should prevent that
> the dir entry of an inode is being moved around to another i_pos while
> it's being changed?
>
> But in the pre-patch version of fat_write_inode, shouldn't then
> mark_buffer_dirty(bh) be called when the lock is still held?

I meant, read/write of storage might sleep, so it shouldn't hold
spin_lock when does it.

If you set debug CONFIG_* of locking, I guess it will warn.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>