From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756593AbZEDNtD (ORCPT ); Mon, 4 May 2009 09:49:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754479AbZEDNsu (ORCPT ); Mon, 4 May 2009 09:48:50 -0400 Received: from mail-ew0-f224.google.com ([209.85.219.224]:62491 "EHLO mail-ew0-f224.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755874AbZEDNst (ORCPT ); Mon, 4 May 2009 09:48:49 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:message-id:from:to:cc:subject:user-agent:mime-version :content-type; b=Uvdal0FLo05w9jcWHlzGoNF0J7z51HbUpkZ/3KDsHa+I9n7gr95MDEzAAVDUMXsoim FhYwXzpNNBSNuGKBJyvgDscdjjxQ1V2hR1OOZfPC2/nha0Y1zHBaFf3liqfuBomy6/SP bpdyq91SezVNMIy1QNXIozIDz2GKrunqXVKcc= Date: Mon, 04 May 2009 15:48:45 +0200 Message-ID: <878wld0yiq.wl%vmayatsk@redhat.com> From: Vitaly Mayatskikh To: linux-kernel@vger.kernel.org Cc: Kristen Carlson Accardi , Jeff Garzik Subject: [PATCH] Avoid world-writable sysfs files in libata driver User-Agent: Wanderlust/2.15.6 (Almost Unreal) Emacs/22.3 Mule/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Avoid world-writable sysfs files in libata driver. Signed-off-by: Vitaly Mayatskikh --- drivers/ata/libata-scsi.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 2733b0c..68d9132 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -313,7 +313,7 @@ ata_scsi_em_message_show(struct device *dev, struct device_attribute *attr, return ap->ops->em_show(ap, buf); return -EINVAL; } -DEVICE_ATTR(em_message, S_IRUGO | S_IWUGO, +DEVICE_ATTR(em_message, S_IRUGO | S_IWUSR, ata_scsi_em_message_show, ata_scsi_em_message_store); EXPORT_SYMBOL_GPL(dev_attr_em_message); @@ -366,7 +366,7 @@ ata_scsi_activity_store(struct device *dev, struct device_attribute *attr, } return -EINVAL; } -DEVICE_ATTR(sw_activity, S_IWUGO | S_IRUGO, ata_scsi_activity_show, +DEVICE_ATTR(sw_activity, S_IWUSR | S_IRUGO, ata_scsi_activity_show, ata_scsi_activity_store); EXPORT_SYMBOL_GPL(dev_attr_sw_activity); -- 1.6.2.2 -- wbr, Vitaly