From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0C8BFBF0 for ; Tue, 27 Jan 2026 01:12:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476342; cv=none; b=crc70hF0Uu3wKyEgHxEE4DIkwEbJfnqdF1ljaRZ3N5+rX+uJGRMoRQ9UHigTH04xU+ZqNm+9YUoQbEgwwgiVaDKPLFzc2x5o5mH0A0xPN0B92iDqvj7zW8yo3PoJu97RyMm0wGKy6u0c/NSVjK/v79kKwyCCDndijW9ytxsZ2W0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769476342; c=relaxed/simple; bh=dJZYkXLww1VVjmgCTGY4U2deQ2roIk/KnWbJvfQspKc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FDgDdEHuX0hBdUKB3kfHGnfCrIgSqwLtVizL6Eem1c+O2+jpLaLqT+gpsgwQQJZ5FVPr3b2MwByyh2jdBKmwvKN/yxokeu9Cswdlm5Nqeg4azYHlzTphvlT9iTNx/J1kg8XzDhYM2EaaUb3kh6WgfTygP1tHObagwFieEKZCFNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MagFvMW2; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MagFvMW2" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2a08c65fceeso8515795ad.2 for ; Mon, 26 Jan 2026 17:12:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769476340; x=1770081140; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jSwU+Ks+JulPZbOfkes69hc/O2U1jcNe9cfjRlOkhrY=; b=MagFvMW2j1NUHhswa49J2kYKmprFaRdWmDceVMtHXzCX+c4ZLi6/AeFgFSgRYh/uL7 nhm4FPTQjTqVXExx7jKrc1+zPGQPT615EJJISK3gfomBP2kVhORnKnpAp6QMFiuafKro pQJkUY7sKInmGU6UrzUlBiQGVcW52su8SIn36zzagJfO9iRJXUdcU3C0qk6pOiXfpLqV 7pwHEUEMRLB/2Pg5WHRLrS+a8gpGi2lFNopHt2BU5Jq18H7F4NNy4uCEpqSruonUj+sc I2g8igWNEZeeYYBOU+Sla6Ifcq2zzkhFuwToJ01rQNKqD/98TQGVCq2lK+TeKFTPMf+5 rPvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769476340; x=1770081140; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jSwU+Ks+JulPZbOfkes69hc/O2U1jcNe9cfjRlOkhrY=; b=v4WO9ZK9hskt18cP92o0oVXyFOScCziN/wIn9dn70SCSwq7YtF9IfSdSgCFIDGzk2H TnwJ0bScA6eDt3EoCbUcsUD00tHC9jvrYkU9Kjf1pSZepKG0QMUwcWkjYSZm6FN+lUOK gQsxWQ3p+zdO7I8oM/h5PhpwF6EMR9vHNHyyK8sgCDaBL9iE/IXjkShjn40zpN3NF2Ud UmaO4crnKe/qKCWzoE3tHWPEtkTHDzFaPxcda2qG9rZgyhJYe2e52V69GGBnWB1Pa0uJ 4f1SNfxRt9Ft2896pZk6YL0lgtKgRP1mCBod+S64DrKZ/XcEHfY2ag2/zeg938gW580n SxOg== X-Forwarded-Encrypted: i=1; AJvYcCVuT1cfwC/BIJTZJfWEmgue5bJ4gKyNv/2O0hryv4hHp3GUySZ4aKKqgZOb5rGfoiNrm1pUxfckHHR7ZpQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwE7NmcboUphOUzlCobK0zdZo7rlMFcDSdrHY1aujg+AA2buDI2 onLdPXD1QjHZa/yhUf9YVJO15gin2JgzesqQ7NTifSJbioN1oJ8DnBnq X-Gm-Gg: AZuq6aJKUMfOcCvJ6twSeiYnkjB8OieTRb/1UsMRpmlZXbEbEZbCGxLqKEKRtpojpRk t/eqWUC6p9vJo8/9YzgbfJXV4Sl8onM/mNf8nAF0ye+Sc8S1XSu4eU3AuIT4Zg2iaxEDgYrA5YA u04uI7mzykPiAceSfa7EjnhiHugTNI92l6EgCsY4YIt4nO20tmrqMCrjlobsIKO/t6iM0dmF7mi yk81WCWJ/eMQ3eRd+NCEHONqB3wfZlsGC1oy4110lgZMLTuCqbu/+AI9sN04PERT8qaEEYoKeqt 5g4MQn0lGCGPgQ/mclGeHp9kTFmllU8atiNEGPZsi68zCmvYBZr4Dx/mk6881WECL5yI+AYq0mY bABRKt5eDmDrOKzvZ4ekk4weJXdiOHm7xyWkNaF69hSw0j/yKQkhUR5EyeoMpi3f9j+Qlp+56Vj AxA9jy6HJMU0ow7LARO6Jp X-Received: by 2002:a17:903:458d:b0:2a0:b7cd:d9c6 with SMTP id d9443c01a7336-2a870de2404mr229435ad.6.1769476339939; Mon, 26 Jan 2026 17:12:19 -0800 (PST) Received: from [192.168.1.7] ([159.192.80.104]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2a802f97ba6sm100426775ad.50.2026.01.26.17.12.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 17:12:19 -0800 (PST) Message-ID: <8794178c-0522-4532-b21e-3904f90619f6@gmail.com> Date: Tue, 27 Jan 2026 08:12:15 +0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] usb: csc-acm: add Infineon/Comneon modem support (1519:0020) To: Svyatoslav Ryhel Cc: Oliver Neukum , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260122151746.7745-1-clamor95@gmail.com> <20260122151746.7745-2-clamor95@gmail.com> <8a7ed9d1-c667-418a-a72a-d8d24ed0f9f8@gmail.com> Content-Language: en-US From: Lars Melin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-01-26 21:55, Svyatoslav Ryhel wrote: /snip > > Bus 001 Device 002: ID 1519:0020 Comneon HSIC Device > Couldn't open device, some information will be missing > Negotiated speed: High Speed (480Mbps) > Device Descriptor: > bLength 18 > bDescriptorType 1 > bcdUSB 2.00 > bDeviceClass 2 [unknown] > bDeviceSubClass 0 [unknown] > bDeviceProtocol 0 > bMaxPacketSize0 64 > idVendor 0x1519 Comneon > idProduct 0x0020 HSIC Device > bcdDevice 12.74 > iManufacturer 1 Comneon > iProduct 2 HSIC Device > iSerial 3 0123456789 > bNumConfigurations 1 > Configuration Descriptor: > bLength 9 > bDescriptorType 2 > wTotalLength 0x0111 > bNumInterfaces 8 > bConfigurationValue 1 > iConfiguration 0 > bmAttributes 0xc0 > Self Powered > MaxPower 100mA > Interface Association: > bLength 8 > bDescriptorType 11 > bFirstInterface 0 > bInterfaceCount 2 > bFunctionClass 2 [unknown] > bFunctionSubClass 2 [unknown] > bFunctionProtocol 1 > iFunction 0 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 0 > bAlternateSetting 0 > bNumEndpoints 1 > bInterfaceClass 2 [unknown] > bInterfaceSubClass 2 [unknown] > bInterfaceProtocol 1 > iInterface 4 > CDC Header: > bcdCDC 1.10 > CDC Union: > bMasterInterface 0 > bSlaveInterface 1 > CDC Call Management: > bmCapabilities 0x00 > bDataInterface 1 > CDC ACM: > bmCapabilities 0x07 > sends break > line coding and serial state > get/set/clear comm features > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x85 EP 5 IN > bmAttributes 3 > Transfer Type Interrupt > Synch Type None > Usage Type Data > wMaxPacketSize 0x0040 1x 64 bytes > bInterval 4 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 1 > bAlternateSetting 0 > bNumEndpoints 2 > bInterfaceClass 10 [unknown] > bInterfaceSubClass 0 [unknown] > bInterfaceProtocol 0 > iInterface 5 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x81 EP 1 IN > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x01 EP 1 OUT > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Interface Association: > bLength 8 > bDescriptorType 11 > bFirstInterface 2 > bInterfaceCount 2 > bFunctionClass 2 [unknown] > bFunctionSubClass 2 [unknown] > bFunctionProtocol 1 > iFunction 0 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 2 > bAlternateSetting 0 > bNumEndpoints 1 > bInterfaceClass 2 [unknown] > bInterfaceSubClass 2 [unknown] > bInterfaceProtocol 1 > iInterface 6 > CDC Header: > bcdCDC 1.10 > CDC Union: > bMasterInterface 2 > bSlaveInterface 3 > CDC Call Management: > bmCapabilities 0x00 > bDataInterface 3 > CDC ACM: > bmCapabilities 0x07 > sends break > line coding and serial state > get/set/clear comm features > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x86 EP 6 IN > bmAttributes 3 > Transfer Type Interrupt > Synch Type None > Usage Type Data > wMaxPacketSize 0x0040 1x 64 bytes > bInterval 4 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 3 > bAlternateSetting 0 > bNumEndpoints 2 > bInterfaceClass 10 [unknown] > bInterfaceSubClass 0 [unknown] > bInterfaceProtocol 0 > iInterface 7 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x82 EP 2 IN > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x02 EP 2 OUT > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Interface Association: > bLength 8 > bDescriptorType 11 > bFirstInterface 4 > bInterfaceCount 2 > bFunctionClass 2 [unknown] > bFunctionSubClass 2 [unknown] > bFunctionProtocol 1 > iFunction 0 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 4 > bAlternateSetting 0 > bNumEndpoints 1 > bInterfaceClass 2 [unknown] > bInterfaceSubClass 2 [unknown] > bInterfaceProtocol 1 > iInterface 8 > CDC Header: > bcdCDC 1.10 > CDC Union: > bMasterInterface 4 > bSlaveInterface 5 > CDC Call Management: > bmCapabilities 0x00 > bDataInterface 5 > CDC ACM: > bmCapabilities 0x07 > sends break > line coding and serial state > get/set/clear comm features > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x87 EP 7 IN > bmAttributes 3 > Transfer Type Interrupt > Synch Type None > Usage Type Data > wMaxPacketSize 0x0040 1x 64 bytes > bInterval 4 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 5 > bAlternateSetting 0 > bNumEndpoints 2 > bInterfaceClass 10 [unknown] > bInterfaceSubClass 0 [unknown] > bInterfaceProtocol 0 > iInterface 9 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x83 EP 3 IN > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x03 EP 3 OUT > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Interface Association: > bLength 8 > bDescriptorType 11 > bFirstInterface 6 > bInterfaceCount 2 > bFunctionClass 2 [unknown] > bFunctionSubClass 2 [unknown] > bFunctionProtocol 1 > iFunction 0 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 6 > bAlternateSetting 0 > bNumEndpoints 1 > bInterfaceClass 2 [unknown] > bInterfaceSubClass 2 [unknown] > bInterfaceProtocol 1 > iInterface 10 > CDC Header: > bcdCDC 1.10 > CDC Union: > bMasterInterface 6 > bSlaveInterface 7 > CDC Call Management: > bmCapabilities 0x00 > bDataInterface 7 > CDC ACM: > bmCapabilities 0x07 > sends break > line coding and serial state > get/set/clear comm features > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x88 EP 8 IN > bmAttributes 3 > Transfer Type Interrupt > Synch Type None > Usage Type Data > wMaxPacketSize 0x0040 1x 64 bytes > bInterval 4 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 7 > bAlternateSetting 0 > bNumEndpoints 2 > bInterfaceClass 10 [unknown] > bInterfaceSubClass 0 [unknown] > bInterfaceProtocol 0 > iInterface 11 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x84 EP 4 IN > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x04 EP 4 OUT > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Hi, I can't see anything wrong with the union descriptor in your listing. What is your reason for adding this device to cdc-acm? thanks Lars