From: Aviv Laufer <aviv.laufer@gmail.com>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>,
eric.miao@marvell.com, linux-kernel@vger.kernel.org
Subject: Re: Bug in tdo24m
Date: Mon, 29 Jun 2009 08:57:59 +0300 [thread overview]
Message-ID: <87972c700906282257s368c7ddud4ecf06d50c882e2@mail.gmail.com> (raw)
In-Reply-To: <4A481B88.30806@gmail.com>
Hi,
I tested in on my PXA-270 board.
The patch was submitted and I guess it's waiting for approval
Aviv
On Mon, Jun 29, 2009 at 4:40 AM, Eric Miao<eric.y.miao@gmail.com> wrote:
> Richard Purdie wrote:
>> Hi,
>>
>> On Tue, 2009-06-23 at 15:16 +0300, Aviv Laufer wrote:
>>> I have found a bug in tdo24m.c .
>>> There is a call to kmalloc with the second param is sizeeof (flag)
>>> instead of flag.
>>> This cause a crash.
>>
>> Thats quite a nasty bug and its surprising its not been found before
>> now! Can you resubmit the patch with description and most importantly a
>> Signed-off-by line please (see Documentation/SubmittingPatches)?
>>
>
> Ooops - this is embarrassing, yet I didn't find this causing any crash
> by now, tdo24m works just OK on my Littleton and thus hiding this bug
> deeply.
>
> Aviv,
>
> Any update on this patch? I'd like to queue this ASAP.
>
prev parent reply other threads:[~2009-06-29 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87972c700906230516n538ad959nbd4b1ea21943ffc2@mail.gmail.com>
2009-06-23 12:58 ` Richard Purdie
2009-06-29 1:40 ` Eric Miao
2009-06-29 5:57 ` Aviv Laufer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87972c700906282257s368c7ddud4ecf06d50c882e2@mail.gmail.com \
--to=aviv.laufer@gmail.com \
--cc=eric.miao@marvell.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®