From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Haavard Skinnemoen <hskinnemoen@gmail.com>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 4/4] AVR32-pio: Replace two seq_printf() calls by seq_puts() in pio_bank_show()
Date: Sun, 16 Oct 2016 22:36:24 +0200 [thread overview]
Message-ID: <87a03775-1025-8efe-3fd6-7b52491896b2@users.sourceforge.net> (raw)
In-Reply-To: <c76c4e36-3e5d-3106-69b7-907133c8b7d0@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 16 Oct 2016 22:18:31 +0200
Strings which did not contain data format specifications should be put
into a sequence. Thus use the corresponding function "seq_puts".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/avr32/mach-at32ap/pio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/avr32/mach-at32ap/pio.c b/arch/avr32/mach-at32ap/pio.c
index abbe1b5..7fae6ec 100644
--- a/arch/avr32/mach-at32ap/pio.c
+++ b/arch/avr32/mach-at32ap/pio.c
@@ -367,9 +367,9 @@ static void pio_bank_show(struct seq_file *s, struct gpio_chip *chip)
(mask & pdsr) ? "hi" : "lo",
(mask & pusr) ? " " : "up");
if (ifsr & mask)
- seq_printf(s, " deglitch");
+ seq_puts(s, " deglitch");
if ((osr & mdsr) & mask)
- seq_printf(s, " open-drain");
+ seq_puts(s, " open-drain");
if (imr & mask)
seq_printf(s, " irq-%d edge-both",
gpio_to_irq(chip->base + i));
--
2.10.1
next prev parent reply other threads:[~2016-10-16 20:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-16 20:32 [PATCH 0/4] AVR32-AT32AP: Fine-tuning for three function implementations SF Markus Elfring
2016-10-16 20:33 ` [PATCH 1/4] AVR32-clock: Use seq_putc() in two functions SF Markus Elfring
2016-10-16 20:34 ` [PATCH 2/4] AVR32-clock: Combine nine seq_printf() calls into one call in clk_show() SF Markus Elfring
2016-10-16 20:35 ` [PATCH 3/4] AVR32-pio: Use seq_putc() in pio_bank_show() SF Markus Elfring
2016-10-16 20:36 ` SF Markus Elfring [this message]
2016-10-23 11:58 ` [PATCH 4/4] AVR32-pio: Replace two seq_printf() calls by seq_puts() " Hans-Christian Noren Egtvedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a03775-1025-8efe-3fd6-7b52491896b2@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=egtvedt@samfundet.no \
--cc=hskinnemoen@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®