From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA95539F175 for ; Mon, 16 Mar 2026 15:15:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773674149; cv=none; b=ubAGB+SbAVi6TTfNzpQPO1MpYSvIofP82zaHddJUF3ACQckeYo0oosAQ9fWW/bVzziWaUij8Izs5BFuLRZKFt1OXp1wmZ9zJSez2fOAHLKDCKbN0Zu3au55xusjIoyxW4gN0vnQDRa05zrVoykUxslxYN26f2Asv6dXZqtUIiW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773674149; c=relaxed/simple; bh=8AubT9zETLO3J0yhalp2EoKWnXlbZ0igEmByf+LsasI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QWCHbDA9+E4pUYtK6DiycUUF/aRui3NjfXSscunCc2SVwltWo345+6dYY6shYOMxyrLqQACebO/f9x2G4breC/OcBjohXLgCUUK5tl+GYWXmgyawju5IAG+WgrDIsZbHmbYZngzQhJQMsz6ylZACBoY6ygGPoS2oStXrYJ42Dsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T7j/Oj7H; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PtPvDpJ5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T7j/Oj7H"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PtPvDpJ5" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62GBe5th1066849 for ; Mon, 16 Mar 2026 15:15:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8dtgclFV0NdJiTfOLgw6vPOoHOLrS1waSp0036mEAgQ=; b=T7j/Oj7HDDC0+1dm EVimfT6urucrPqiV3MnkwGRRArh+qgN76mU09Tf1pb/RNf82o/0YXyR3Z55mj+Lr /47cyenKgG+L4rdd6AYfRaRZlrxe4GjhYe+x2lEV3LOfPkFZhZR734UAX/PxzpI3 /VfzWX5r6M9ITUXqt8Z0GOwNUoD7yAdLMpGa0oQkVqjOS3acBfHTkTJbf5+ZjuNA zfw1aBkX+5RHufK8ZX5NV+SZacJIIrRedE6F98NzpIBnBS0v/1j0tWTNRtJBlBoU YQaijVtxQNBxw8xHnkzJntnWrqcwSagkC64ve2XQpZOYmPJG5QPR/aXEIEGfjrEV tW83nA== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cw027ee5j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 15:15:46 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-5ffc46c792cso1110896137.1 for ; Mon, 16 Mar 2026 08:15:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773674146; x=1774278946; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8dtgclFV0NdJiTfOLgw6vPOoHOLrS1waSp0036mEAgQ=; b=PtPvDpJ5+I3jVFfUa3vqBNOT4cl79QJbSkylTQGUd1meWlgMHimZe9IQUoWc2kguds bUOC/e3FYz1JpIQ0dJpwxo1xe6SpOoPbk4AElcKZHV+rVkNfgFjaVV2jY9t/8H4krZIi 0R/af3yrpGrxqQRW2RqzD0ZcWP16vJNK+mShQG6BsP1pifVB21dKqIZlkZrNwoeWX4br HWr3W8gzLtrTNLRuhFfkFGfJMopPmL9ASKUkY1ptgjC4UVADZwJu12t3koZNMU9AxclI LJnD8c5dscNatKNms5DxaQlVc+RUZUz8JfTdUYxeR6V+Sqn9UjTgGEiQlB3ZJSJLuwx9 Vk2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773674146; x=1774278946; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8dtgclFV0NdJiTfOLgw6vPOoHOLrS1waSp0036mEAgQ=; b=MaOwGq2XwGdIdiJVfsI7ULVGqmVb0BAZMkXXaQShaeIN3549cS37OJOj+Mz92lPJ8Y zMdcmaLGw+e9x8ZF2UtNWCfrGh1nHGavdbtaeIoVCIZjtRVQXAUqFjG6Y3nGAbQhTMIz cDKEfndlKxe+gnZtouuW4x+xYzXP5eGo19gqc9hTgpZn6l/izuOYsXaKqWyxLclQbEgE 8esz8Z+4bPsVDX0jHREPnY61Hnz4xAo/BBAnMSziMxltQwqoQQieCDqtho0vjAY1Vxln 9OXwJvTosiHBIsOw+eV4K2Gue1VENkzyk2Q/XMmZ2IPlMyPrpI21YcfazzHmLggQkTEA tCTA== X-Forwarded-Encrypted: i=1; AJvYcCV3Spi7loqr5WBJPxUhmZkfqVJ1fWRWMNN25XjaQN3W8oEcQu/SE/WIYU5v01kuXnLJgoUp/XXTBv0X4Vk=@vger.kernel.org X-Gm-Message-State: AOJu0Yzg8O87fAkiqboiGPN97kYsUgY9J7f8lCX/0st3JKY45KLUwOpD XdyvhI1kcpFgmAjEcaCW4QaxJQ1t4FlaIZ4w4HpQwHdeRYU9MUDIFelImupamy9TAWZdJTTfYft 9wC06JTN0tC8Ox59Zzrf/wQvPaTd345QZ1gmmIoCq3wcVwizGy9OqswcWCbcJ7nEtPPs= X-Gm-Gg: ATEYQzxqUKcSSiTaVsaMET6G6wyONGcCSeK98DbX1SlrXWrhCnEleIrovOp+Z2NzWAm K0BfGUD1cvQxb+J8RRfHVP4Z6mZ8nTqQmvQZurLFZIxhA9OadcJgkzGIZjORJc0OM49tvl7NDSN DMEb+X4WvnXdJrQg90yOfj5BdS+k01rV4+mnBFRMnkQrM/dOANZP9cvRXB9x6LXFKVkwLryne6B J7+tz1dCdviZ/gXKtID4NMnt4asAefbO9Ef7DPh+yV41Zj5msOw6c7RdR75dBpoJCjROg7aRhUZ Kf2d4VTeZ/Nuw+VsDVPXSH/RaiUP3TqWq7RxIm4RyFk9cs6kZAmUjUD/xZ1hB1fj2M/fxcwY3GV eT/knsUvli44kZWVnQLVON1eir7fXvNfrErQkUcwAJ3MovD1lovOYHIBTRa8LSKQ9De4XOyy3J5 J+Cpk= X-Received: by 2002:a05:6102:548f:b0:5ff:dabc:db57 with SMTP id ada2fe7eead31-6020e67699amr2409064137.7.1773674145868; Mon, 16 Mar 2026 08:15:45 -0700 (PDT) X-Received: by 2002:a05:6102:548f:b0:5ff:dabc:db57 with SMTP id ada2fe7eead31-6020e67699amr2409030137.7.1773674145396; Mon, 16 Mar 2026 08:15:45 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9791c30cf3sm455238266b.2.2026.03.16.08.15.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 08:15:42 -0700 (PDT) Message-ID: <87a103cf-d066-4319-ab68-bea3463c0fa2@oss.qualcomm.com> Date: Mon, 16 Mar 2026 16:15:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: hamoa: Fix OPP tables for all DisplayPort controllers To: Dmitry Baryshkov Cc: Abel Vesa , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rajendra Nayak , Abel Vesa , Sibi Sankar , Jagadeesh Kona , Taniya Das , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260309-hamoa-fix-dp3-opp-table-v1-1-1a8141d71f9f@oss.qualcomm.com> <2f4e4cc7-2600-482e-88d9-d4b20d328a72@oss.qualcomm.com> <7d8211c5-7b12-4349-a329-cfb51a918a1c@oss.qualcomm.com> <6qhpiiroqnpzg44i2j5rgmlw7uaffw4t5z6gv2kgubfoqpktpd@r7h75knlv5a2> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <6qhpiiroqnpzg44i2j5rgmlw7uaffw4t5z6gv2kgubfoqpktpd@r7h75knlv5a2> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: YahElR_OPryXvUo0yFHusiBuS_jxbxYg X-Proofpoint-ORIG-GUID: YahElR_OPryXvUo0yFHusiBuS_jxbxYg X-Authority-Analysis: v=2.4 cv=AqXjHe9P c=1 sm=1 tr=0 ts=69b81ea2 cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=qqbVkrzGGpSu_KmFPysA:9 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDExNSBTYWx0ZWRfX9CjWNYPe5apq nC7kx6w1T5W6fROakjXlRfXp5Bwnpqd70ROYvbK9EMxe2CZJ1FGUfcom8agxoaob6Q1invdR9IN +0AdcPJHDgo3vFdnUKLQVPeOUu4M4LW4elI7wVBy7P1ygINOeSFlWbDkJmtRgnb5rUqNylqmTrI A6iHXXcn3SR1dl5Y16kj6drp/IPxj0nsoUONpymEUQVg3dj6Vopv7L4msANZbezBEmG4bO7Wrka nSzo+crJODyaBoip052Hr1YLk2f6mI/1TWs36wVC9FwTm+ZnIwfytmxXr7a47XKMDOlX+K8b1u6 j8epST3kZ1Ke9PbJE13b5bnAiCG1APYAKi4sq0yChYEf2i8zsOkefA5D6CUVtXFqA10wJ8xBvjd C5vDONKIiXFyVrKDfcU9lVs6utlUqOW/RAZZt0dgn8M4uV38CQ2Dxz2rzddMd7LevQSn/vJxUty xKwUPsUzWE1pE6rx2sQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-16_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160115 On 3/16/26 3:27 PM, Dmitry Baryshkov wrote: > On Mon, Mar 16, 2026 at 10:27:11AM +0100, Konrad Dybcio wrote: >> On 3/13/26 6:39 PM, Dmitry Baryshkov wrote: >>> On Tue, Mar 10, 2026 at 11:36:26AM +0100, Konrad Dybcio wrote: >>>> On 3/9/26 3:44 PM, Abel Vesa wrote: >>>>> According to internal documentation, the corners specific for each rate >>>>> from the DP link clock are: >>>>> - LOWSVS_D1 -> 19.2 MHz >>>>> - LOWSVS -> 270 MHz >>>>> - SVS -> 540 MHz (594 MHz in case of DP3) >>>> >>>> This discrepancy sounds a little odd.. can we get some confirmation >>>> that it's intended and not an internal copypasta? (+Jagadeesh, Taniya) >>>> FWIW DP3 is not USB4- or MST-capable so it may as well be >>> >>> DP3 link_clock is sourced from the eDP PHY. I assume there might some >>> >>>> >>>>> - SVS_L1 -> 594 MHz >>>>> - NOM -> 810 MHz >>>>> - NOM_L1 -> 810 MHz >>>>> - TURBO -> 810 MHz >>>>> >>>>> So fix all tables for each of the four controllers according to the >>>>> documentation. >>>> >>>> It sounds like a good move to instead keep only a single table for >>>> DP012 and a separate one for DP3 if it's really different >>>> >>>>> The 19.2 @ LOWSVS_D1 isn't needed as the controller will select 162 MHz >>>>> for RBR, which falls under the 270 MHz and it will vote for that LOWSVS >>>>> in that case. >>>> >>>> Even though the Linux OPP framework agrees with that sentiment today (it >>>> will set the correct rate via clk APIs and the correct rpmh vote for a rate >>>> that's >= 162), I have mixed feelings about relying on that >>> >>> Why? 19.2 isn't an actual working frequency, as far as I can understand >>> anything. Or is it a working OPP for running "shared" clocks? >> >> No, I meant removing the 162 case and relying on OPP to pick up the >> required-opps value from the next entry > > Isn't it a documented way how the OPP tables work? yes/no, there's a mention in dev_pm_opp_set_rate(): """ An OPP entry specifies the highest frequency at which other of the OPP entry apply. [...] """ if you insist, we can rely on it.. Konrad