From: Mark Lord <mlord@pobox.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Jiri Kosina" <jikos@kernel.org>,
"Bastien Nocera" <hadess@hadess.net>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
"Peter F . Patel-Schneider" <pfpschneider@gmail.com>,
"Filipe Laíns" <lains@riseup.net>,
"Nestor Lopez Casado" <nlopezcasad@logitech.com>
Subject: Re: [PATCH] HID: logitech-hidpp: Handle timeout differently from busy
Date: Mon, 5 Jun 2023 10:31:39 -0400 [thread overview]
Message-ID: <87a3b3fd-e7b0-d6b5-af80-f14557cbbc33@pobox.com> (raw)
In-Reply-To: <jafrw2wirzegnf7v2pcm52sao5yc4futa7ok4ccmywigj3y2c4@pep4b3ebus7s>
On 2023-06-05 10:20 AM, Benjamin Tissoires wrote:
>
> On Jun 03 2023, Mark Lord wrote:
..
>> I wonder if this code could be re-worked to not even do this (waiting)
>> from the _probe() function? It ought to be able to throw it on a workqueue
>> or something, rather than stalling system boot for a minimum of 5-seconds
>> (or much longer as as-is).
>
> That's an option, but the fact that I can not replicate locally with the
> exact same hardware seems to indicate that we would just be papering
> over the issue.
>
> Here, I admittely have the USB receiver running through USB-C ports, and
> the communication never fails and I get immediate bring ups of the
> devices. Which means I am not hitting that path.
>
> The hidpp driver should have everything ready to delay the init in a
> workqueue, but the impacted users would still get a delay when they plug
> in the device (which is better than stalling the boot, I agree).
..
Oddly, it's only a boot-time thing.
If I unplug the Logitech Unifying receiver, wait a few seconds,
and then plug it back in.. my mouse, keyboard, and touchpad all work immediately.
Unlike during boot.
--
Mark Lord
next prev parent reply other threads:[~2023-06-05 14:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 8:24 Bastien Nocera
2023-05-31 14:07 ` Jiri Kosina
2023-06-03 12:41 ` Jiri Kosina
2023-06-03 13:17 ` Mark Lord
2023-06-05 14:20 ` Benjamin Tissoires
2023-06-05 14:31 ` Mark Lord [this message]
2023-06-05 8:44 ` Linux regression tracking (Thorsten Leemhuis)
2023-06-05 14:27 ` Benjamin Tissoires
2023-06-05 16:25 ` Mark Lord
2023-06-05 17:04 ` Benjamin Tissoires
2023-06-05 17:47 ` Mark Lord
2023-06-05 20:03 ` Jiri Kosina
2023-06-06 13:27 ` Jiri Kosina
2023-06-06 18:18 ` Linux regression tracking (Thorsten Leemhuis)
2023-06-06 18:37 ` Benjamin Tissoires
2023-06-07 9:46 ` Greg Kroah-Hartman
2023-06-07 10:07 ` Benjamin Tissoires
2023-06-15 7:24 ` Linux regression tracking (Thorsten Leemhuis)
2023-06-15 11:24 ` Mark Lord
2023-06-21 14:03 ` Linux regression tracking (Thorsten Leemhuis)
2023-06-21 15:10 ` Benjamin Tissoires
2023-06-21 17:19 ` Linux regression tracking (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a3b3fd-e7b0-d6b5-af80-f14557cbbc33@pobox.com \
--to=mlord@pobox.com \
--cc=benjamin.tissoires@redhat.com \
--cc=hadess@hadess.net \
--cc=jikos@kernel.org \
--cc=lains@riseup.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nlopezcasad@logitech.com \
--cc=pfpschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®