From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
Deepanshu Kartikey <kartikey406@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+e91dc13b1b37759b3d9f@syzkaller.appspotmail.com
Subject: Re: [PATCH] wifi: ath9k: stop WMI event tasklet from rescheduling itself on probe failure
Date: Wed, 21 Oct 2026 10:36:09 +0200 [thread overview]
Message-ID: <87a4o7tpqe.fsf@toke.dk> (raw)
In-Reply-To: <1e1238a6-399d-4cb5-a5ab-756ccac64169@oss.qualcomm.com>
> Fix: mirror ath9k_wmi_event_drain's pattern in the tasklet early-exit:
> if (READ_ONCE(wmi->stopped)) {
> spin_lock_irqsave(&wmi->wmi_lock, flags);
> __skb_queue_purge(&wmi->wmi_event_queue);
> spin_unlock_irqrestore(&wmi->wmi_lock, flags);
> return;
> }
I think this fix is overly verbose; we don't actually need to drain the
queue twice; if we just bail out of ath9k_wmi_event_tasklet() when the
stopped flag is set, we can drain the queue from ath9k_stop_wmi().
There's already a helper (ath9k_wmi_event_drain()) that takes the right
lock, so we can use that.
I'll send an updated patch, please drop this one.
-Toke
prev parent reply other threads:[~2026-10-21 8:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 2:11 Deepanshu Kartikey
2026-10-18 10:47 ` Deepanshu Kartikey
2026-10-19 19:25 ` Toke Høiland-Jørgensen
2026-10-21 0:38 ` Jeff Johnson
2026-10-21 8:36 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4o7tpqe.fsf@toke.dk \
--to=toke@toke.dk \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=kartikey406@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=syzbot+e91dc13b1b37759b3d9f@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®