From: Takashi Iwai <tiwai@suse.de>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>, Sen Wang <sen@ti.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Clemens Ladisch <clemens@ladisch.de>, Peng Fan <peng.fan@nxp.com>,
Zhao Dongdong <zhaodongdong@kylinos.cn>,
Arun Raghavan <arunr@valvesoftware.com>,
Fu Hao <fuhao@open-hieco.net>,
Joakim Zhang <joakim.zhang@cixtech.com>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA/ASoC: use assign_bit() where applicable
Date: Mon, 28 Sep 2026 13:09:11 +0200 [thread overview]
Message-ID: <87a4p17huw.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260918141532.3022761-1-peng.fan@oss.nxp.com>
On Fri, 18 Sep 2026 16:15:20 +0200,
Peng Fan (OSS) wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Convert open-coded if/else with set_bit/clear_bit and their
> non-atomic __set_bit/__clear_bit variants to the assign_bit/__assign_bit
> API.
>
> Done with Coccinelle semantic patch:
> // set_bit -> clear_bit => assign_bit
>
> @@
> expression cond, bit, addr;
> @@
>
> -if (cond)
> - set_bit(bit, addr);
> -else
> - clear_bit(bit, addr);
> +assign_bit(bit, addr, cond);
>
> // clear_bit -> set_bit => assign_bit
>
> @@
> expression cond, bit, addr;
> @@
>
> -if (cond)
> - clear_bit(bit, addr);
> -else
> - set_bit(bit, addr);
> +assign_bit(bit, addr, !cond);
>
> // __set_bit -> __clear_bit => __assign_bit
>
> @@
> expression cond, bit, addr;
> @@
>
> -if (cond)
> - __set_bit(bit, addr);
> -else
> - __clear_bit(bit, addr);
> +__assign_bit(bit, addr, cond);
>
> // __clear_bit -> __set_bit => __assign_bit
>
> @@
> expression cond, bit, addr;
> @@
>
> -if (cond)
> - __clear_bit(bit, addr);
> -else
> - __set_bit(bit, addr);
> +__assign_bit(bit, addr, !cond);
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Applied to for-next branch now. Thanks.
Takashi
prev parent reply other threads:[~2026-09-28 11:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 14:15 Peng Fan (OSS)
2026-09-18 22:14 ` Mark Brown
2026-09-28 11:09 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4p17huw.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=arunr@valvesoftware.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=clemens@ladisch.de \
--cc=fuhao@open-hieco.net \
--cc=joakim.zhang@cixtech.com \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=perex@perex.cz \
--cc=sen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
--cc=zhaodongdong@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®