From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB2C136C9D0 for ; Wed, 19 Aug 2026 20:59:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787173180; cv=none; b=ok4gqMmkX4cnNMHi/avA2nwHfKSUrZaMmj5LUsVrB0bzrnw3vIvZxXlcoHLP92jQNW+Quq8JS35/s4CDROvhPS3ZsfXZT7SzG7Ie1M3Vk62B54XWtmh0+DEIRvbAL0Lo8DS7XnExFfH+rKKlVNwfkjDKj1hf7LNuwsUnuiCszso= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787173180; c=relaxed/simple; bh=z+Qp8d0a2bcgo9URIiRJQFgWjW/mVVESCmlY300to8M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=tTaNKHgg5eWu10/kBxMSmOJwnDmRj1CHYzs231RxQYhVeIyzsGthv1RJy/JNGeBCe+qW/wTcuTEbF8ZK3dNqb0MI8ja0fLlzV9KHiNnhKZikHHHJlbDjKomJRCxYVWeY8QU/jjLjjOSOQJLBqt0MPCG7QSbW4Tyc62nGzHYV/Zs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Fr8mic0R; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Fr8mic0R" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D693A1F000E9; Wed, 19 Aug 2026 20:59:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787173179; bh=/Mjv/O3h12aMLT26Q9+GrN+ovY9UMk1QjtaP5rGOang=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=Fr8mic0RkAqtm2DZIOaDFlF7YOO4ekNOMbxtiuKowwEUyD0DoNRbsK7AF0RAIlKWc GoZm4+qWRKpenBsw9QJQDx/BhpbKUskPJMD3aZWbQw8K3f8Duk/5x8N1x6gpcSgJii 8YOS/sgHzdS4jSaqdKoRwV4G9YVknCBxBQAN0OfkfA4J0svGjKohJb0tL4/26QTXAD nj1vlo3/zgXRgMGHF0amuDkX/RQNIL+ASrhFWVt0OfrG5PYypO058CnRBNLiUCRTwE SB7c258oE2Qc9E/ufw6D62BhJIuG+qNY7ZOXtCBwBZ2CVbnkbEqdPWJCcRaK/euXkW 1NjK8xl3CWJHg== From: Thomas Gleixner To: Nathan Chancellor Cc: Linus Torvalds , linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [GIT pull] timers/cleanups for v7.3-rc1 In-Reply-To: <20260819184803.GA3333711@ax162> References: <178696575118.1270771.17154447195623102039.tglx@fw13> <178696575847.1270771.17330908414715876847.tglx@fw13> <20260819184803.GA3333711@ax162> Date: Wed, 19 Aug 2026 22:59:36 +0200 Message-ID: <87a4qhkerr.ffs@fw13> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Aug 19 2026 at 11:48, Nathan Chancellor wrote: >> -int read_current_timer(unsigned long *timer_val) >> +bool delay_read_timer(unsigned long *timer_val) >> { >> if (!delay_timer) >> - return -ENXIO; >> - >> + return false; >> *timer_val = delay_timer->read_current_timer(); >> - return 0; >> + return true; >> } >> -EXPORT_SYMBOL_GPL(read_current_timer); >> +EXPORT_SYMBOL_GPL(delay_read_timer); >> >> static inline u64 cyc_to_ns(u64 cyc, u32 mult, u32 shift) >> { > > I bisected a hang that I see after getting to userspace when virtually > testing some ARM configurations to commit dfc256dac54c ("calibrate: > Rework delay timer calibration"). It looks like the branches in > get_cycles() were not updated for the changed meaning of the return of > delay_read_timer()? This appears to resolve it for me but I am not sure > if I am missing something. > > diff --git a/arch/arm/include/asm/timex.h b/arch/arm/include/asm/timex.h > index 94e40c19cfc5..4d31eab9dba2 100644 > --- a/arch/arm/include/asm/timex.h > +++ b/arch/arm/include/asm/timex.h > @@ -13,7 +13,7 @@ typedef unsigned long cycles_t; > // Temporary workaround until timex.h is cleaned up > bool delay_read_timer(unsigned long *t); > > -#define get_cycles() ({ cycles_t c; delay_read_timer(&c) ? 0 : c; }) > +#define get_cycles() ({ cycles_t c; delay_read_timer(&c) ? c : 0; }) Duh, yes. Stupid me. Can you please send a patch wuth a proper change log and a Fixes tag? Thanks, tglx