From: Takashi Iwai <tiwai@suse.de>
To: songxiebing <songxiebing@kylinos.cn>
Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: hda: Check snd_hda_power_pm construct error before executing verb
Date: Wed, 22 Jul 2026 13:26:02 +0200 [thread overview]
Message-ID: <87a4rjgt9x.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260717024948.506335-1-songxiebing@kylinos.cn>
On Fri, 17 Jul 2026 04:49:48 +0200,
songxiebing wrote:
>
> From: Bob Song <songxiebing@kylinos.cn>
>
> When userspace writes 1 to /sys/bus/pci/devices/XX/remove to remove HDA PCI device,
> the HDA hardware control path is shut down and devres unmaps the BAR virtual address
> bus->remap_addr automatically during driver removal.
>
> If a delayed HDA verb command arrives after the MMIO region is unmapped, the driver
> will access invalid virtual addresses and trigger a page fault splat.
>
> So add an error check right after constructing snd_hda_power_pm:
>
> Signed-off-by: Bob Song <songxiebing@kylinos.cn>
> ---
> Changes in v2:
> - Modify the judgment from pm_runtime_datus_stuspended to bus->core.chip_init
Applied to for-next branch. Thanks.
Takashi
next prev parent reply other threads:[~2026-07-22 11:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 2:04 [PATCH] " songxiebing
2026-07-13 10:13 ` Takashi Iwai
2026-07-14 2:13 ` songxiebing
2026-07-14 5:26 ` Takashi Iwai
2026-07-17 2:49 ` [PATCH v2] " songxiebing
2026-07-22 11:26 ` Takashi Iwai [this message]
2026-07-17 5:33 ` [PATCH v3] " songxiebing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4rjgt9x.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=songxiebing@kylinos.cn \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®