From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB512425CEE for ; Tue, 16 Jun 2026 16:27:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781627259; cv=none; b=gh8AuDGBOw68eGklRZMmiqnW/arf1Mvn4KzUckoIoR2Yky37vTyC2/QCBHxMDFT1rNnC+u2MWgLpuH3T0aJptWgzsFZaZSil9mSO1x32OsvBjg+y8xBE0UmiNy8AiwQXobzADI3sZSMGrkoywOMmmHNZay/Ag+8uClDkS4uX24g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781627259; c=relaxed/simple; bh=kUghcp6LbEAXRYmNtVjn2OnzfDOMmCET7f0ph/Dtj7g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=MMqExhvDGNT/WjABJ7QA/gepF4lCdgpPA6bpyZ3YCPxn6s82PuvtOkppK4UbIqRk+jlWVF+gkxTDYFSFLr2+wvsBSE+kDahkD18M9LVpWrvDZ2POw4VxRw3WhxLdiAriTy86r1mRElGvzZNQAY6b2KSHl1wHwmvy5m52Bw7X3fQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=F7RuiFC3; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=QEQIoxqw; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="F7RuiFC3"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="QEQIoxqw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781627256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ONTRu09Dr+Ry3nIH2CFE3AeVpsjq5ZCjzHdim5kHqGk=; b=F7RuiFC3wpqb3RzYXXRvkxu2zymOSFZj89P1MFsiqa+f8UQ7ev35Xu3PDhF/QD2XmoR+4M SdI+wgDiqjzETK4eD700OD869IoRn4i4J+2LO5z5nUb2O9QIw4cxIAWf8ByA6gcmMCF569 1T6OHdONoXwGCP0PptUxx2Avwu3MiiA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-u3gaHdTLOg2iPWVuR1KOBw-1; Tue, 16 Jun 2026 12:27:35 -0400 X-MC-Unique: u3gaHdTLOg2iPWVuR1KOBw-1 X-Mimecast-MFC-AGG-ID: u3gaHdTLOg2iPWVuR1KOBw_1781627254 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-490b37e1f48so32791985e9.0 for ; Tue, 16 Jun 2026 09:27:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781627254; x=1782232054; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=ONTRu09Dr+Ry3nIH2CFE3AeVpsjq5ZCjzHdim5kHqGk=; b=QEQIoxqw82riJoFiHRnuFw6umnPPEQ7h4SmDPsgH+ePyThRQAdWWl94Y2eYzh4/W58 QYdnxevbF5K3bTkqun/bkOt3SO4O02C4dPTb4EPtgm2Axyq4QMiTbGxFU1ZhXVDbgLzl DJ0Mvxv6kAaM1t19YaS3NR7hqP2DyQ76hZIWd2cl/lnSYMymAZl14UsQTID/hGxcmPVe mCHQR5Ci/Dvs4LgyOCyBo7a9TP6DU2jtLxLZ47SqugR2Lr4ilceblUqCI56aE8qN0cTP C9am/U8KQjPvEsXBuv3zYOiLM4WA/Ua7Zmrs5O7TCqa4dC3xHwSw5jh7deVsHqqag+PA 02vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781627254; x=1782232054; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ONTRu09Dr+Ry3nIH2CFE3AeVpsjq5ZCjzHdim5kHqGk=; b=AffhO5ZxOczYd7Gaw/ITGlG5NvKq3ZFXVKnS5mL1oxsNEN4ffAf7YF7T4WONH1vrv4 1NwFAniLZp4x5opDey+4asjWwzwaggYjpFe5+Q7/+YltEvD0u17TOLut/Tqt6PdNfSeC phLYNPusCh7kDO7Puyogsg3ccgkWUCV3jF2NBq/DWyvUoPJMUbxBpKW2RiPUSZLDyCu6 HM4kOSzsCQM6BJI8cK8gI69hvIkhlClCBmaGwOc55OO6RFMaKCrKregtj2CVrLE5w/aV BoY8ZgrsCAyXurvxCuPBd1ccNmSxpb9PP+F1gMOhacDqK0YZfxUIXKhdWR3NtI4hFsuO 15XA== X-Forwarded-Encrypted: i=1; AFNElJ+zeS0eeJywi4D5wxcZ2NPbTZb2zxMgI5k32b4kPAJYmMxLFh9YLHZvzYRbVlWKuttxgNg9vxmt5Bghr4w=@vger.kernel.org X-Gm-Message-State: AOJu0YyvYbMS33kCWbABaeFozZII/ApCGJBgnDo31JzBcH2A8WxMxsus Pwvu6UivAeyX+yJ5e9PME4y6tnFYRVahtW8G39+TJZn4Fs5f2aPjHX8TYcwTqorpjhJJ0pgGzXr OqebR5pN/Fx9UXcaNWNHxd0FgUb4VSMe0dQNDatMq7KOt5z1r+5erxRrl9aV29YTNjQ== X-Gm-Gg: Acq92OGgfr1ymcFrkRTCel8bfQQ6B9jv3aP3OLlP3KU5BUOShM7yyp+hJG7PHeY88M8 OksoL2HP6CoraS42JVsnvI1AbbdbiKMDolodA5u22HFay9eR90IgO7QylDSb+3L0V0m5ioY/WJ4 SfYVGuXfCKC8ClpnLf67OoMKmgr0qVT/1/clkZ2ZBdn1qxUveLcAV9MQf38/f5Sq1nvXod5VXvD qjiQldgFMzbs9wDaVI+lVGzJ6zPTZZdwov3ERCJMP8eDugMCAEcuuUnZHMQ8Q06hj/+LmbJ5xQN k+F7hmdPQTa0kIPegE3Mwczyk2gMZcTKOI8oQpYbw3qHRX+H8OhQ62xWK06q9dvhnf0tVQIw6iK AJiA5vOmoN3UJZQmdoBuxwkz2zl0pr2K8VWaO1LJa7XTaYmH+rZJP7qglRXO1D26UUZmFM0XXfZ iABCbO X-Received: by 2002:a05:600d:848a:b0:492:1e36:bb04 with SMTP id 5b1f17b1804b1-492333f84acmr2657345e9.37.1781627254325; Tue, 16 Jun 2026 09:27:34 -0700 (PDT) X-Received: by 2002:a05:600d:848a:b0:492:1e36:bb04 with SMTP id 5b1f17b1804b1-492333f84acmr2656865e9.37.1781627253899; Tue, 16 Jun 2026 09:27:33 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-461eaa0d275sm2513344f8f.2.2026.06.16.09.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 09:27:32 -0700 (PDT) From: Javier Martinez Canillas To: Conor Dooley , Amit Barzilai Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, airlied@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, simona@ffwll.ch, tzimmermann@suse.de Subject: Re: [PATCH v2] dt-bindings: display: Add Solomon SSD1351 OLED controller In-Reply-To: <20260616-nautical-obstinate-a92fd80ef483@spud> References: <20260615175620.88828-1-amit.barzilai22@gmail.com> <20260616-nautical-obstinate-a92fd80ef483@spud> Date: Tue, 16 Jun 2026 18:27:31 +0200 Message-ID: <87a4suzc0c.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Conor Dooley writes: Hello Conor, > On Mon, Jun 15, 2026 at 08:56:20PM +0300, Amit Barzilai wrote: >> Add a device tree binding for the Solomon SSD1351, a 128x128 65k-color >> RGB OLED display controller driven over a 4-wire SPI bus. The binding >> builds on the shared solomon,ssd-common.yaml properties already used by >> the other Solomon display controllers. >> >> Assisted-by: Claude:claude-opus-4-8 >> Signed-off-by: Amit Barzilai >> --- >> Changes since v1: >> - Drop solomon,width / solomon,height: both are deducible from the >> compatible and are already declared (as optional) by the referenced >> solomon,ssd-common.yaml, so a local override is unnecessary. >> - Drop the rotation property: it has no consumer (rotation is being removed from the driver). >> - Use dt-bindings/gpio/gpio.h flag defines in the example >> (reset-gpios active-low, dc-gpios active-high). > > The user for this appears to be in staging. As far as I understand, the > policy is that we only add bindings for staging things when they move > out of staging. > Sure, this is straightforward but why should an exception be made here? > Are you working on moving this out of staging? > This DT binding was part of a series to add support for "solomon,ssd1351" to drivers/gpu/drm/solomon/ DRM driver. Amit only sent a v2 of the binding schema because he had some questions about the driver: https://lore.kernel.org/dri-devel/87cxxqzwxn.fsf@ocarina.mail-host-address-is-not-set/ But yes, I agree that it would had been better for him to post this as a part of v2 (and I still expect him to do it), otherwise it is confusing. Specially since as you pointed out, there is an existing fbdev driver for the same device in staging. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat